Replies: 8 comments 11 replies
-
|
we are a bit overdue for making that release.. Since those earlier 0.4.0 to 0.4.3 versions weren't actually tagged I am thinking it is fine to just disregard them and restart at 0.4.0 - what do you guys think? then we can just make the release asap.. |
Beta Was this translation helpful? Give feedback.
-
Yep, this is why the release drafter went back to I'm okay with just restarting it back to We should also start using the labels (I'm guilty of not using them 😅) so that the PRs get moved into the proper heading and the bumps correspond to the proper version. |
Beta Was this translation helpful? Give feedback.
-
|
Sounds good to me. Looks like
Agreed, I've been starting to add them to my own PRs. Some of the older ones will have to be updated retroactively |
Beta Was this translation helpful? Give feedback.
-
|
Yes, I just realized that all the uncategorized ones are just listed in Changes -- I just changed a label to see what happens, but is there a way to re-trigger building the release draft? |
Beta Was this translation helpful? Give feedback.
-
|
Not at the moment without re-running the bump workflow (which would presumably cause another version bump). I could quickly set up a workflow requiring a manual trigger that runs the |
Beta Was this translation helpful? Give feedback.
-
|
Trigger is implemented now to update the release-draft. Below is an example of the before and after running the workflow after adding a tag to an existing PR. Before: After: It triggers the same way a "deploy" should be triggered from the actions workflow tab. |
Beta Was this translation helpful? Give feedback.
-
|
Very nice. So we can retroactively go into merged PRs and add labels? |
Beta Was this translation helpful? Give feedback.
-
|
Yep, though it will really only affect the PRs that have changed since the last release, so anything past that may not change (haven't tested). |
Beta Was this translation helpful? Give feedback.
-
|
Does the current deploy workflow leave room for manually editing (i.e. by typing) the release changelog. In other words, does the deploy workflow regenerate the changelog, or does it publish it as is? @kaitj |
Beta Was this translation helpful? Give feedback.
-
|
The deploy workflow would regenerate the changelog since that action is being called in order to publish. You could manually edit it after the fact and it shouldn't change anything. Other option would be to update the PR prior to publishing. I've never really run into this so I'm not sure whether it updates to PR will update the changelog via release-drafter after it is published. |
Beta Was this translation helpful? Give feedback.
-
|
I see, okay, makes sense |
Beta Was this translation helpful? Give feedback.
-
|
I've gone through and added labels to the two PRs that didn't have them for |
Beta Was this translation helpful? Give feedback.
-
|
I'm good with that! Feel free to publish the release!
…On Fri., Dec. 10, 2021, 6:05 p.m. Jason Kai, ***@***.***> wrote:
I've gone through and added labels to the two PRs that didn't have them
for 0.4.0. If we're happy with those, then we can run the release
workflow, otherwise happy to change the labels.
@pvandyken <https://github.com/pvandyken> @tkkuehn
<https://github.com/tkkuehn> @akhanf <https://github.com/akhanf>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/akhanf/snakebids/discussions/90#discussioncomment-1789072>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACXV2XJR5244R4UQGPXJ7VTUQKBSBANCNFSM5JRQ5DJA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Beta Was this translation helpful? Give feedback.
-
|
Sounds good, thanks! |
Beta Was this translation helpful? Give feedback.
-
|
Ok I'm publishing the release now (in case it has to be a repo admin to do it) |
Beta Was this translation helpful? Give feedback.
-
|
OOPS I screwed that one up.. looks like I was supposed to run the deploy workflow instead of publishing the release.. |
Beta Was this translation helpful? Give feedback.
-
|
I think manually-recoverable -- I will remove the 0.4.1 pypi package, delete the v0.4.1 tag, then poetry publish the v0.4.0 tagged version.. |
Beta Was this translation helpful? Give feedback.
-
|
OK all set now 0.4.0 is in pypi -- I yanked 0.4.1 from pypi, when it comes time to make that release it might need a manual deploy to force replace it, not sure, we'll see! |
Beta Was this translation helpful? Give feedback.
-
|
I can see it now! |
Beta Was this translation helpful? Give feedback.
-
@kaitj It looks like there's currently a draft
0.4.0release. I remember you mentioned that was because we hadn't actually tagged our previous0.4.0release. Is there a plan to get this all resolved?Beta Was this translation helpful? Give feedback.
All reactions