Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PEP 621-based pyproject.toml in snakebids create #313

Closed
tkkuehn opened this issue Jun 23, 2023 · 3 comments
Closed

Use PEP 621-based pyproject.toml in snakebids create #313

tkkuehn opened this issue Jun 23, 2023 · 3 comments

Comments

@tkkuehn
Copy link
Contributor

tkkuehn commented Jun 23, 2023

The problem

The setup.py we create isn't super useful and is setuptools-specific, so we should use something a bit more standard (and incidentally maybe move toward support for hatch) by implementing a pyproject.toml that has the fields defined in PEP 621.
This was referenced Jun 24, 2023
Closed
Merged
@kaitj
Copy link
Contributor

kaitj commented Jul 17, 2023

Think this may have been brought up during the initial discussions too and not opposed to moving towards supporting hatch, but this poetry PR is one we should also keep an eye on as they move towards PEP 621.

python-poetry/poetry-core#567

@pvandyken
Copy link
Contributor

Great, glad to see they're moving to support it

@pvandyken
Copy link
Contributor

pvandyken commented Dec 13, 2023 •
edited
Loading

This has been resolved by #336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tkkuehn @kaitj @pvandyken