fix: Resolve the error coming up during local project setup #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mrcoder991
reviewed
Jun 14, 2024
| const initDimensions = { | ||
| height: 0, | ||
| width: 0, | ||
| }; |
There was a problem hiding this comment.
The initDimensions object is a good addition. This ensures initial state is predictable.
| @@ -13,18 +15,21 @@ export default function useWindowDimensions() { | |||
There was a problem hiding this comment.
In the useWindowDimensions function, you don't need to pass hasWindow to getWindowDimensions since it's already defined inside useEffect. The hasWindow check can just be used directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Fixes Issue
Closes #53
👨💻 Changes proposed
typeof window !== 'undefined'creates an error. Refer https://nextjs.org/docs/messages/react-hydration-erroruseWindowDimensionshook and used the same logic inside useEffect so that this logic runs only on client✔️ Check List (Check all the applicable boxes)