Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show autocomplete suggestions for File Query Filters on Obsidian App #1128

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

samhoooo
Copy link
Contributor

@samhoooo samhoooo commented Mar 4, 2025

Closes #1025

Show autocomplete suggestions for File Query Filters on Obsidian App

Changes

  • When you type in search modal, and matches the pattern file:, you should see list of all files in vault and non-vault
  • This list is filtered down as you type more letters

Technical Details

  • Added file filter mode (isFileFilterMode state) to filter search results by specific files
  • Updated getSuggestions() function to search file from vault and non-vault via khoj backend.
  • Updated the selection behavior to handle both file selection and search result selection

Testing

  • Test deleting user messages
  • Test deleting Khoj responses
  • Verify both messages in a turn are removed
  • Verify deletion persists after page refresh
  • Verify no delete button on setup hint
  • Verify no delete button on error message
  • Verify no delete button on conversation starter
  • Test error cases (network failure, etc)

Screensort

demo.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show autocomplete suggestions for File Query Filters on Obsidian App
1 participant