Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DOM Scripting, Add CSP to Web config pages. Disable CSP in Obsidian plugin #834

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use DOM Scripting, Add CSP to Web config pages. Disable CSP in Obsidian plugin #834

wants to merge 3 commits into from

Conversation

debanjum
Copy link
Member

  • c65bd8e Add CSP to web config pages. Load phone no. validation js, css from S3
  • 1c6bc11 Construct config page elements on Web via DOM scripting
  • 719db82 Disable CSP in Khoj Obsidian as it interferes with Obsidian functionality

@debanjum
Disable CSP in Khoj Obsidian as it interferes with Obsidian functiona…
719db82 
…lity

The Khoj CSP interferes with other Obsidian features and plugins as
CSP is applied page wide.

For now chat message sanitization via Dompurify should suffice.

Enable CSP when can scope it to only the Khoj Obsidian plugin.
@debanjum
Construct config page elements on Web via DOM scripting.
1c6bc11 
Minimize isage of innerHTML to prevent DOM clobbering and unintended
escape by user Input
@debanjum
Add CSP to web config pages. Load phone no validation js, css from S3
c65bd8e
@debanjum debanjum requested a review from sabaimran June 26, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabaimran sabaimran Awaiting requested review from sabaimran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@debanjum