-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support daisyui v4 #39
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Axel Meinhardt <[email protected]>
Signed-off-by: Axel Meinhardt <[email protected]>
Signed-off-by: Axel Meinhardt <[email protected]>
Thank you for compiling it together, works for me so far with [email protected], hopefully @kidonng will take a look and merge it. |
index.ts
Outdated
* @param {ChildNode} currentNode - The current node to examine. | ||
*/ | ||
const collectNonAtrules = (currentNode: ChildNode) => { | ||
if (currentNode.type === 'atrule') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to do the following change to make TSC happy:
if (currentNode.type === 'atrule') { | |
if (currentNode.type === 'atrule' && currentNode.nodes) { |
Just for everyone using this with Daisy v4. Looks like this has an issue with button hover handling, probably because the piece of styling is wrapped in both I was able to work around it by adding the following styles manually: @media (hover: hover) {
@supports (color:color-mix(in oklab,black,black)) {
.btn:hover {
background-color: color-mix(in oklab,oklch(var(--btn-color,var(--b2))/var(--tw-bg-opacity,1)) 90%,black);
border-color: color-mix(in oklab,oklch(var(--btn-color,var(--b2))/var(--tw-border-opacity,1)) 90%,black);
}
}
} |
@ameinhardt @kidonng |
For Astro one needs to add this at the very top file possible as global, unscoped CSS style: <style is:global>
... The mentioned workaround here ...
</style> |
Any news? |
Signed-off-by: Axel Meinhardt <[email protected]>
Signed-off-by: Axel Meinhardt <[email protected]>
summing up changes from #38 by @LeekJay with minimal changes