-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix #295 , 500 server errors on POST to sequencing-centers. #296
Conversation
Fixes 500 server errors on POST to sequencing-centers. See marshmallow-code/flask-marshmallow#44
What was the error being thrown here? Can it be reproduced + tested? |
Both sides of the error are described in #295 |
Hmm ok, I'm guessing this is due to the fact that it needs to make a query in the serializer to ensure that the name is unique |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Remember to rebase on master manually first before merging.
I was able to reproduce it locally. So we may want to hold off on merging this PR and make another PR to address the larger problem. I've confirmed that this happens any time you try to POST any entity with a given kf_id. Also, not sure about this but I think we may need to add in some validation on kf_ids (ensuring that the correct prefixes exist depending on the entity). We may as well do that all in one PR |
I see. Looks like maybe we wanted to include a |
#308 is a general fix for this problem. |
Fixed by #308 |
Fixes #295 , 500 server errors on POST to sequencing-centers.
See marshmallow-code/flask-marshmallow#44