-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DROOLS-7558 : SSH clone: Fetch roles for the logged in user from the realm itself #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins run fdb |
Rikkola
force-pushed
the
DROOLS-7558-ssh
branch
from
September 20, 2023 15:17
ff0743b
to
263d0b8
Compare
Rikkola
changed the title
Fix without tests
DROOLS-7558 : SSH clone: Fetch roles for the logged in user from the realm itself
Sep 20, 2023
Jenkins run fdb |
Rikkola
force-pushed
the
DROOLS-7558-ssh
branch
from
September 22, 2023 05:59
263d0b8
to
33f2517
Compare
Jenkins run fdb |
Kudos, SonarCloud Quality Gate passed! |
@domhanak This should work. I uploaded and linked a war. |
was this already reviewed? @domhanak just curious |
tomasdavidorg
requested review from
tomasdavidorg
and removed request for
domhanak
December 6, 2023 13:30
@mareknovotny I will take a look. |
tomasdavidorg
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks 🙂
mareknovotny
added
backport-7.67.x
Generate backport PR for 7.67.x branch
backport-7.67.x-blue
Generate backport PR for 7.67.x-blue branch
labels
Dec 8, 2023
mareknovotny
pushed a commit
that referenced
this pull request
Dec 12, 2023
…realm itself (#1404) (#1407) Co-authored-by: Toni Rikkola <[email protected]>
mareknovotny
pushed a commit
that referenced
this pull request
Dec 12, 2023
…realm itself (#1404) (#1408) Co-authored-by: Toni Rikkola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-7.67.x
Generate backport PR for 7.67.x branch
backport-7.67.x-blue
Generate backport PR for 7.67.x-blue branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
DROOLS-7558
WorkbenchUserManager depends on the Elytron file system realm and for that reason can not find or log in the user.
war
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
a pull request please add comment: Jenkins retest this
a full downstream build please add comment: Jenkins run fdb
a compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.