Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DROOLS-7475 Proposed feature for ['key'] accessor #56

Merged
merged 17 commits into from
Jun 22, 2023
Merged

DROOLS-7475 Proposed feature for ['key'] accessor #56

merged 17 commits into from
Jun 22, 2023

Commits on Jun 19, 2023

  1. DROOLS-7475 Proposed feature for ['key'] accessor 

    nesting the protoextractor into the maven build
    @tarilabs
    tarilabs committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    a4f6afe View commit details
    Browse the repository at this point in the history

  2. WIP: broken but progressing 

    Results :

Failed tests:   testWithSelectAttr(org.drools.ansible.rulebook.integration.api.NullTest): expected:<1> but was:<0>
  test(org.drools.ansible.rulebook.integration.api.NullTest): expected:<1> but was:<0>
  testRepeatedOnceWithin(org.drools.ansible.rulebook.integration.api.OnceWithinTest): expected:<0> but was:<1>
  testOnceWithinWithOr(org.drools.ansible.rulebook.integration.api.OnceWithinTest): expected:<0> but was:<1>
  testOnceWithinWithAnd(org.drools.ansible.rulebook.integration.api.OnceWithinTest): expected:<0> but was:<1>
  testSelectOnNull(org.drools.ansible.rulebook.integration.api.SelectTest): expected:<1> but was:<0>

Tests in error:
  testOnceWithinInRule(org.drools.ansible.rulebook.integration.api.OnceWithinTest): Cannot invoke "java.util.Map.get(Object)" because "map" is null
  testOnceWithinInCondition(org.drools.ansible.rulebook.integration.api.OnceWithinTest): Cannot invoke "java.util.Map.get(Object)" because "map" is null
  testOnceAfterWithOr(org.drools.ansible.rulebook.integration.api.OnceAfterTest): Cannot invoke "Object.toString()" because the return value of "org.drools.base.facttemplates.Fact.get(String)" is null

Tests run: 138, Failures: 6, Errors: 3, Skipped: 0
    @tarilabs
    tarilabs committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    1cd8cf9 View commit details
    Browse the repository at this point in the history

  3. WIP: broken but null != UNDEF 

    Results :

Failed tests:   testRepeatedOnceWithin(org.drools.ansible.rulebook.integration.api.OnceWithinTest): expected:<0> but was:<1>
  testOnceWithinWithOr(org.drools.ansible.rulebook.integration.api.OnceWithinTest): expected:<0> but was:<1>
  testOnceWithinWithAnd(org.drools.ansible.rulebook.integration.api.OnceWithinTest): expected:<0> but was:<1>

Tests in error:
  testOnceWithinInRule(org.drools.ansible.rulebook.integration.api.OnceWithinTest): Cannot invoke "java.util.Map.get(Object)" because "map" is null
  testOnceWithinInCondition(org.drools.ansible.rulebook.integration.api.OnceWithinTest): Cannot invoke "java.util.Map.get(Object)" because "map" is null
  testOnceAfterWithOr(org.drools.ansible.rulebook.integration.api.OnceAfterTest): Cannot invoke "Object.toString()" because the return value of "org.drools.base.facttemplates.Fact.get(String)" is null

Tests run: 138, Failures: 3, Errors: 3, Skipped: 0
    @tarilabs
    tarilabs committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    7493fde View commit details
    Browse the repository at this point in the history

  4. WIP: broken but progressing 

    Failed tests:   testRepeatedOnceWithin(org.drools.ansible.rulebook.integration.api.OnceWithinTest): expected:<0> but was:<1>
  testOnceWithinInRule(org.drools.ansible.rulebook.integration.api.OnceWithinTest): expected:<0> but was:<1>
  testOnceWithinWithOr(org.drools.ansible.rulebook.integration.api.OnceWithinTest): expected:<0> but was:<1>
  testOnceWithinWithAnd(org.drools.ansible.rulebook.integration.api.OnceWithinTest): expected:<0> but was:<1>
  testOnceWithinInCondition(org.drools.ansible.rulebook.integration.api.OnceWithinTest): expected:<0> but was:<1>
  testOnceAfterWithOr(org.drools.ansible.rulebook.integration.api.OnceAfterTest): expected:<2> but was:<1>

Tests run: 138, Failures: 6, Errors: 0, Skipped: 0
    @tarilabs
    tarilabs committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    7cd6073 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. ALL tests passing

    @tarilabs
    tarilabs committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    941af73 View commit details
    Browse the repository at this point in the history

  2. small refactor

    @tarilabs
    tarilabs committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    7db369b View commit details
    Browse the repository at this point in the history

  3. cleanup RulesModelUtil

    @tarilabs
    tarilabs committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    b1cf0d7 View commit details
    Browse the repository at this point in the history

  4. refactor, small fix for array access, tests

    @tarilabs
    tarilabs committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    5f6004c View commit details
    Browse the repository at this point in the history

  5. fix grammar typo

    @tarilabs
    tarilabs committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    2ebf1f4 View commit details
    Browse the repository at this point in the history

  6. refactor ExistsField as discussed with Mario

    @tarilabs
    tarilabs committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    bc9cb36 View commit details
    Browse the repository at this point in the history

  7. implement code review feedback

    @tarilabs
    tarilabs committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    0f41f50 View commit details
    Browse the repository at this point in the history

  8. implement code review feedback

    @tarilabs
    tarilabs committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    f6ccd37 View commit details
    Browse the repository at this point in the history

  9. code review feedback impl about ORIGINAL_MAP_FIELD

    @tarilabs
    tarilabs committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    b536459 View commit details
    Browse the repository at this point in the history

  10. BREAKING to investigate indexing issue

    @tarilabs
    tarilabs committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    b2602bb View commit details
    Browse the repository at this point in the history

  11. revert the disabled commit

    @tarilabs
    tarilabs committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    08c78d3 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. implement code review feedback

    @tarilabs
    tarilabs committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    4dc4656 View commit details
    Browse the repository at this point in the history

  2. code review feedback

    @tarilabs
    tarilabs committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    896b925 View commit details
    Browse the repository at this point in the history