improve code as RuleUnitInstance is AutoCloseable.

kiegroup · Oct 27, 2023 · 753943a · 753943a
1 parent f1354bd
commit 753943a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/...del-ruleunit-archetype/src/main/resources/archetype-resources/src/test/java/RuleTest.java b/...del-ruleunit-archetype/src/main/resources/archetype-resources/src/test/java/RuleTest.java
@@ -60,8 +60,7 @@ public void test() {
         LOG.info("Creating RuleUnit");
         MeasurementUnit measurementUnit = new MeasurementUnit();
 
-        RuleUnitInstance<MeasurementUnit> instance = RuleUnitProvider.get().createRuleUnitInstance(measurementUnit);
-        try {
+        try (RuleUnitInstance<MeasurementUnit> instance = RuleUnitProvider.get().createRuleUnitInstance(measurementUnit)) {
             LOG.info("Insert data");
             measurementUnit.getMeasurements().add(new Measurement("color", "red"));
             measurementUnit.getMeasurements().add(new Measurement("color", "green"));
@@ -74,8 +73,6 @@ public void test() {
             assertTrue("contains red", measurementUnit.getControlSet().contains("red"));
             assertTrue("contains green", measurementUnit.getControlSet().contains("green"));
             assertTrue("contains blue", measurementUnit.getControlSet().contains("blue"));
-        } finally {
-            instance.close();
         }
     }
 }
diff --git a/...t/resources/projects/integrationtestDefaults/reference/src/test/java/it/pkg/RuleTest.java b/...t/resources/projects/integrationtestDefaults/reference/src/test/java/it/pkg/RuleTest.java
@@ -40,8 +40,7 @@ public void test() {
         LOG.info("Creating RuleUnit");
         MeasurementUnit measurementUnit = new MeasurementUnit();
 
-        RuleUnitInstance<MeasurementUnit> instance = RuleUnitProvider.get().createRuleUnitInstance(measurementUnit);
-        try {
+        try (RuleUnitInstance<MeasurementUnit> instance = RuleUnitProvider.get().createRuleUnitInstance(measurementUnit)) {
             LOG.info("Insert data");
             measurementUnit.getMeasurements().add(new Measurement("color", "red"));
             measurementUnit.getMeasurements().add(new Measurement("color", "green"));
@@ -54,8 +53,6 @@ public void test() {
             assertTrue("contains red", measurementUnit.getControlSet().contains("red"));
             assertTrue("contains green", measurementUnit.getControlSet().contains("green"));
             assertTrue("contains blue", measurementUnit.getControlSet().contains("blue"));
-        } finally {
-            instance.close();
         }
     }
 }