[RHDM-2007] non-matching rule fires randomly and results in infinite-loop

[tkobayas]

• [KIE-686] fix peer update propagation for FromNode

• Update drools-test-coverage/test-compiler-integration/src/test/java/org/drools/compiler/integrationtests/UnexpectedLoopTest.java

• Fixed for Java 8 compatibility

---

Ports
This is a backport PR of apache/incubator-kie-drools#5584 for 7.x
for 7.67.x -> kiegroup/drools#23
for 7.67.x-blue -> kiegroup/drools#22

JIRA:
https://issues.redhat.com/browse/RHDM-2007

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

• for pull request checks
  Please add comment: Jenkins retest this

• for a specific pull request check
  Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] tests

• for a full downstream build

  • for jenkins job: please add comment: Jenkins run fdb
  • for github actions job: add the label run_fdb

• a compile downstream build please add comment: Jenkins run cdb

• a full production downstream build please add comment: Jenkins execute product fdb

• an upstream build please add comment: Jenkins run upstream

• for quarkus branch checks
  Run checks against Quarkus current used branch
  Please add comment: Jenkins run quarkus-branch

• for a quarkus branch specific check
  Run checks against Quarkus current used branch
  Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch

• for quarkus main checks
  Run checks against Quarkus main branch
  Please add comment: Jenkins run quarkus-main

• for a specific quarkus main check
  Run checks against Quarkus main branch
  Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-main

• for quarkus lts checks
  Run checks against Quarkus lts branch
  Please add comment: Jenkins run quarkus-lts

• for a specific quarkus lts check
  Run checks against Quarkus lts branch
  Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts

• for native checks
  Run native checks
  Please add comment: Jenkins run native

• for a specific native check
  Run native checks
  Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native

• for native lts checks
  Run native checks against quarkus lts branch
  Please add comment: Jenkins run native-lts

• for a specific native lts check
  Run native checks against quarkus lts branch
  Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

[tkobayas]

GHA Windows Java 8 : Flaky tests

2023-11-13T09:22:43.4658019Z [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.408 s <<< FAILURE! - in org.drools.core.time.impl.JDKTimerServiceTest
2023-11-13T09:22:43.4662492Z [ERROR] testSingleExecutionJob(org.drools.core.time.impl.JDKTimerServiceTest)  Time elapsed: 0.798 s  <<< FAILURE!
2023-11-13T09:22:43.4810997Z java.lang.AssertionError:
2023-11-13T09:22:43.4993201Z
2023-11-13T09:22:43.5013947Z Expected size:<1> but was:<0> in:
2023-11-13T09:22:43.5015004Z <[]>
2023-11-13T09:22:43.5016228Z    at org.drools.core.time.impl.JDKTimerServiceTest.testSingleExecutionJob(JDKTimerServiceTest.java:56)
...
2023-11-13T10:44:09.3667262Z [ERROR] Tests run: 10, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 4.629 s <<< FAILURE! - in org.drools.mvel.integrationtests.MBeansMonitoringTest
2023-11-13T10:44:09.3669438Z [ERROR] testAggregatedAndDispose[KieBase type=STREAM_IDENTITY_MODEL_PATTERN](org.drools.mvel.integrationtests.MBeansMonitoringTest)  Time elapsed: 0.016 s  <<< FAILURE!
2023-11-13T10:44:09.3671131Z org.junit.ComparisonFailure: expected:<[tru]e> but was:<[fals]e>

[tkobayas]

@mariofusco Please merge this backport PR, thanks!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[tkobayas]

Note: This backport PR doesn't include moving NodeTypeEnums.hasNodeMemory() to MarshallingHelper.nodeWithMemory() because MarshallingHelper had been moved in master, so its conflict would be a little complex and is not important in this issue.