Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

[7.67.x] [DROOLS-7493] [DROOLS-7497] executable model wrongly rewrites modify in if-block #8

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

tkobayas
Copy link
Contributor

@tkobayas tkobayas commented Oct 12, 2023

This PR also combines [DROOLS-7195] Modify syntax fails when using executable model, works

Ports
This is a backport PR of kiegroup/drools#7 for 7.67.x
This also combines DROOLS-7195 to resolve a merge conflict

JIRA:
https://issues.redhat.com/browse/RHDM-1993

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request checks
    Please add comment: Jenkins retest this

  • for a specific pull request check
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] tests

  • for a full downstream build

    • for jenkins job: please add comment: Jenkins run fdb
    • for github actions job: add the label run_fdb
  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

  • for quarkus branch checks
    Run checks against Quarkus current used branch
    Please add comment: Jenkins run quarkus-branch

  • for a quarkus branch specific check
    Run checks against Quarkus current used branch
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch

  • for quarkus main checks
    Run checks against Quarkus main branch
    Please add comment: Jenkins run quarkus-main

  • for a specific quarkus main check
    Run checks against Quarkus main branch
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-main

  • for quarkus lts checks
    Run checks against Quarkus lts branch
    Please add comment: Jenkins run quarkus-lts

  • for a specific quarkus lts check
    Run checks against Quarkus lts branch
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts

  • for native checks
    Run native checks
    Please add comment: Jenkins run native

  • for a specific native check
    Run native checks
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native

  • for native lts checks
    Run native checks against quarkus lts branch
    Please add comment: Jenkins run native-lts

  • for a specific native lts check
    Run native checks against quarkus lts branch
    Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

…… (#4846) (#4868)

* [DROOLS-7195] Modify syntax fails when using executable model, works with mvel runtime (nested properties)

* - Dropping 'with' statement support
…in if-block (#5380)

* [DROOLS-7493] executable model wrongly rewrites modify in if-block
- Additional tests to cover setter order for properperty reactivity [DROOLS-7497]

* - analyze whole RHS and make all modification as property reactive

* - Add docs about fact modification after modify or update in RHS

* - fixing code smells
@tkobayas
Copy link
Contributor Author

Jenkins run fdb

@tkobayas
Copy link
Contributor Author

GHA Windows Java8 : flaky

2023-10-12T10:45:15.1070330Z [ERROR] testAggregatedAndDispose[KieBase type=STREAM_IDENTITY_MODEL_PATTERN](org.drools.mvel.integrationtests.MBeansMonitoringTest)  Time elapsed: 0 s  <<< FAILURE!
2023-10-12T10:45:15.1071053Z org.junit.ComparisonFailure: expected:<[tru]e> but was:<[fals]e>

GHA Windows Java11 : flaky

2023-10-12T10:55:07.0494508Z [ERROR] testSubmitOnFireUntilHalt[KieBase type=CLOUD_IDENTITY_MODEL_PATTERN](org.drools.mvel.integrationtests.FireUntilHaltTest)  Time elapsed: 0.955 s  <<< FAILURE!
2023-10-12T10:55:07.0517369Z org.junit.ComparisonFailure: expected:<[1]> but was:<[0]>
2023-10-12T10:55:07.6117152Z    at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
2023-10-12T10:55:07.6422537Z    at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
2023-10-12T10:55:07.7621885Z    at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
2023-10-12T10:55:08.1984096Z    at org.drools.mvel.integrationtests.FireUntilHaltTest.testSubmitOnFireUntilHalt(FireUntilHaltTest.java:94)

@tkobayas
Copy link
Contributor Author

tkobayas commented Oct 13, 2023

@mariofusco Please merge this backport PR, thanks!

@mariofusco mariofusco merged commit a40a061 into kiegroup:7.67.x Oct 13, 2023
2 of 4 checks passed
tkobayas added a commit to tkobayas/kiegroup-drools that referenced this pull request Oct 13, 2023
…s modify in if-block (kiegroup#8)

* [DROOLS-7195] Modify syntax fails when using executable model, works … (#4846) (#4868)

* [DROOLS-7195] Modify syntax fails when using executable model, works with mvel runtime (nested properties)

* - Dropping 'with' statement support

* [DROOLS-7493] [DROOLS-7497] executable model wrongly rewrites modify in if-block (#5380)

* [DROOLS-7493] executable model wrongly rewrites modify in if-block
- Additional tests to cover setter order for properperty reactivity [DROOLS-7497]

* - analyze whole RHS and make all modification as property reactive

* - Add docs about fact modification after modify or update in RHS

* - fixing code smells
mariofusco pushed a commit that referenced this pull request Oct 16, 2023
…s modify in if-block (#8) (#9)

* [DROOLS-7195] Modify syntax fails when using executable model, works … (#4846) (#4868)

* [DROOLS-7195] Modify syntax fails when using executable model, works with mvel runtime (nested properties)

* - Dropping 'with' statement support

* [DROOLS-7493] [DROOLS-7497] executable model wrongly rewrites modify in if-block (#5380)

* [DROOLS-7493] executable model wrongly rewrites modify in if-block
- Additional tests to cover setter order for properperty reactivity [DROOLS-7497]

* - analyze whole RHS and make all modification as property reactive

* - Add docs about fact modification after modify or update in RHS

* - fixing code smells
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants