This repository has been archived by the owner on Jan 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
[7.67.x] [DROOLS-7493] [DROOLS-7497] executable model wrongly rewrites modify in if-block #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…… (#4846) (#4868) * [DROOLS-7195] Modify syntax fails when using executable model, works with mvel runtime (nested properties) * - Dropping 'with' statement support
…in if-block (#5380) * [DROOLS-7493] executable model wrongly rewrites modify in if-block - Additional tests to cover setter order for properperty reactivity [DROOLS-7497] * - analyze whole RHS and make all modification as property reactive * - Add docs about fact modification after modify or update in RHS * - fixing code smells
Jenkins run fdb |
GHA Windows Java8 : flaky
GHA Windows Java11 : flaky
|
@mariofusco Please merge this backport PR, thanks! |
mariofusco
approved these changes
Oct 13, 2023
tkobayas
added a commit
to tkobayas/kiegroup-drools
that referenced
this pull request
Oct 13, 2023
…s modify in if-block (kiegroup#8) * [DROOLS-7195] Modify syntax fails when using executable model, works … (#4846) (#4868) * [DROOLS-7195] Modify syntax fails when using executable model, works with mvel runtime (nested properties) * - Dropping 'with' statement support * [DROOLS-7493] [DROOLS-7497] executable model wrongly rewrites modify in if-block (#5380) * [DROOLS-7493] executable model wrongly rewrites modify in if-block - Additional tests to cover setter order for properperty reactivity [DROOLS-7497] * - analyze whole RHS and make all modification as property reactive * - Add docs about fact modification after modify or update in RHS * - fixing code smells
mariofusco
pushed a commit
that referenced
this pull request
Oct 16, 2023
…s modify in if-block (#8) (#9) * [DROOLS-7195] Modify syntax fails when using executable model, works … (#4846) (#4868) * [DROOLS-7195] Modify syntax fails when using executable model, works with mvel runtime (nested properties) * - Dropping 'with' statement support * [DROOLS-7493] [DROOLS-7497] executable model wrongly rewrites modify in if-block (#5380) * [DROOLS-7493] executable model wrongly rewrites modify in if-block - Additional tests to cover setter order for properperty reactivity [DROOLS-7497] * - analyze whole RHS and make all modification as property reactive * - Add docs about fact modification after modify or update in RHS * - fixing code smells
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also combines [DROOLS-7195] Modify syntax fails when using executable model, works
Ports
This is a backport PR of kiegroup/drools#7 for 7.67.x
This also combines DROOLS-7195 to resolve a merge conflict
JIRA:
https://issues.redhat.com/browse/RHDM-1993
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request checks
Please add comment: Jenkins retest this
for a specific pull request check
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] tests
for a full downstream build
run_fdb
a compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream
for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch
for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch
for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main
for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-main
for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts
for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts
for native checks
Run native checks
Please add comment: Jenkins run native
for a specific native check
Run native checks
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native
for native lts checks
Run native checks against quarkus lts branch
Please add comment: Jenkins run native-lts
for a specific native lts check
Run native checks against quarkus lts branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native-lts
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.