Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DROOLS-7540] Coercion from Interger literal to BigDecimal bind variable #2406

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

tkobayas
Copy link
Contributor

@tkobayas tkobayas commented Dec 6, 2023

  • Bump to mvel 2.5.1.Final

Ports
This is a PR for 7.x.
for 7.67.x -> #2408
for 7.67.x-blue -> #2407

JIRA:
https://issues.redhat.com/browse/DROOLS-7540

referenced Pull Requests:

You can check Kiegroup organization repositories CI status from Chain Status webpage

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used locally on command line or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

A general local execution could be the following one, where the tool clones all dependent projects starting from the -sp one and it locally applies the pull request (if it exists) in order to reproduce a complete build scenario for the provided Pull Request.

Note: the tool considers multiple Pull Requests related to each other if their branches (generally in the forked repositories) have the same name.

$ build-chain-action -df 'https://raw.githubusercontent.com/${GROUP:kiegroup}/droolsjbpm-build-bootstrap/${BRANCH:main}/.ci/pull-request-config.yaml' build pr -url <pull-request-url> -sp kiegroup/kie-wb-distributions [--skipExecution]

Consider changing kiegroup/kie-wb-distributions with the correct starting project.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest (using this e.g. Jenkins retest this optional but no longer required)

  • for a full downstream build

    • for jenkins job: please add comment: Jenkins run fdb
    • for github actions job: add the label run_fdb
  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

  • for windows-specific os job add the label windows_check

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@tkobayas
Copy link
Contributor Author

tkobayas commented Dec 6, 2023

Jenkins run fdb

@mareknovotny mareknovotny added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Dec 6, 2023
@tkobayas tkobayas removed the request for review from pibizza December 7, 2023 07:26
@tkobayas
Copy link
Contributor Author

tkobayas commented Dec 7, 2023

@mariofusco Please review and merge with kiegroup/drools#32 if it's okay. Thanks!

@mariofusco mariofusco merged commit 94fe0ce into kiegroup:main Dec 7, 2023
19 of 22 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 7, 2023
github-actions bot pushed a commit that referenced this pull request Dec 7, 2023
mariofusco pushed a commit that referenced this pull request Dec 11, 2023
…mal bind variable (#2407)

* [DROOLS-7540] Coercion from Interger literal to BigDecimal bind variable (#2406)

- Bump to mvel 2.5.1.Final

* revert keycloak version. it should not be in this PR

---------

Co-authored-by: Toshiya Kobayashi <[email protected]>
mariofusco pushed a commit that referenced this pull request Dec 11, 2023
…ind variable (#2408)

* [DROOLS-7540] Coercion from Interger literal to BigDecimal bind variable (#2406)

- Bump to mvel 2.5.1.Final

* revert keycloak version. it should not be in this PR

---------

Co-authored-by: Toshiya Kobayashi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants