-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.67.x-blue] Upgrading Apache Velocity to 2.3 #2473
[7.67.x-blue] Upgrading Apache Velocity to 2.3 #2473
Conversation
Full GAV change: org.apache.velocity:velocity:1.7 -> org.apache.velocity:velocity-engine-core:2.3 NOTE: There are some changes that need to be made to the velocity configuration. These can be found at https://velocity.apache.org/engine/2.3/upgrading.html#upgrading-from-velocity-22-to-velocity-23. Read all changes until 1.7 to 2.0. They all apply to this upgrade. Test and verify any usage of Apache Velocity templates. Signed-off-by: Jason Porter <[email protected]>
jenkins do fdb |
1 similar comment
jenkins do fdb |
again @LightGuard use in the PR summary branch name, please to differentiate the PR in the list |
jenkins do fdb |
if you changed artifactId management where are changed related PRs for repositories downstream ? @LightGuard See here what i did search quickly by https://github.com/search?q=org%3Akiegroup%20velocity&type=code, there is of cource a lot of unrelated hits, but another ones in https://github.com/kiegroup/jbpm-designer/blob/7.67.x-blue/jbpm-designer-backend/pom.xml#L216-L225 |
Looks like I missed the jbpm-designer-backend. I'll have to a more thorough search. kiegroup/kie-wb-common#3829 is in the kie-wb-common. |
jenkins do fdb |
1 similar comment
jenkins do fdb |
jenkins do fdb |
Yay! I got a green build! 🕺🏻 |
@yesamer or @mareknovotny Build is green, looks like we're good to merge the various PRs for this. |
@LightGuard We already merge them, if I'm not wrong :) |
Full GAV change:
org.apache.velocity:velocity:1.7 ->
org.apache.velocity:velocity-engine-core:2.3
Referenced PRs:
NOTE: There are some changes that need to be made to the velocity configuration. These can be found at https://velocity.apache.org/engine/2.3/upgrading.html#upgrading-from-velocity-22-to-velocity-23. Read all changes until 1.7 to 2.0.
They all apply to this upgrade.
Test and verify any usage of Apache Velocity templates.