Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable cron generate_status_page_data execution #2522

Closed
wants to merge 1 commit into from
Closed

Conversation

Ginxo
Copy link
Contributor

@Ginxo Ginxo commented Nov 5, 2024

Thank you for submitting this pull request

JIRA: (please edit the JIRA link if it exists)

link

referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)

  • paste the link(s) from GitHub here
  • link 2
  • link 3 etc.

You can check Kiegroup organization repositories CI status from Chain Status webpage

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used locally on command line or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

A general local execution could be the following one, where the tool clones all dependent projects starting from the -sp one and it locally applies the pull request (if it exists) in order to reproduce a complete build scenario for the provided Pull Request.

Note: the tool considers multiple Pull Requests related to each other if their branches (generally in the forked repositories) have the same name.

$ build-chain-action -df 'https://raw.githubusercontent.com/${GROUP:kiegroup}/droolsjbpm-build-bootstrap/${BRANCH:main}/.ci/pull-request-config.yaml' build pr -url <pull-request-url> -sp kiegroup/kie-wb-distributions [--skipExecution]

Consider changing kiegroup/kie-wb-distributions with the correct starting project.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest (using this e.g. Jenkins retest this optional but no longer required)

  • for a full downstream build

    • for jenkins job: please add comment: Jenkins run fdb
    • for github actions job: add the label run_fdb
  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

  • for windows-specific os job add the label windows_check

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@mareknovotny
Copy link
Member

Is this automatic generation of data annoying someone ? just curious ;) Maybe we can change the frequency?

@Ginxo
Copy link
Contributor Author

Ginxo commented Nov 5, 2024

Is this automatic generation of data annoying someone ? just curious ;) Maybe we can change the frequency?

I receive constant error reports about it, and since I don't see http://kiegroup.github.io/droolsjbpm-build-bootstrap/ working this is my proposal. I would prefer to have the status page working and data generation not reporting issues.

@mareknovotny
Copy link
Member

well, i can see this works https://kiegroup.github.io/droolsjbpm-build-bootstrap/job/productization-jobs but maybe the page partially doesn't i would need to look at it

@Ginxo
Copy link
Contributor Author

Ginxo commented Nov 6, 2024

@mareknovotny
Copy link
Member

i would not say it is wrong, but there is different link when shown, i clicked on it and it directly moves you to https://kiegroup.github.io/droolsjbpm-build-bootstrap/job/productization-jobs. Whatever in deployments it looks like the last several runs are green/OK. So i think we can close this PR? WDYT?

@mareknovotny
Copy link
Member

so i think now all works again? can you confirm @Ginxo there are no reports for you?

@Ginxo
Copy link
Contributor Author

Ginxo commented Nov 12, 2024

so i think now all works again? can you confirm @Ginxo there are no reports for you?

Hi @mareknovotny
still receiving them
image

see https://github.com/kiegroup/droolsjbpm-build-bootstrap/actions/runs/11792370530/job/32845913220

Error: Error getting [https://raw.githubusercontent.com/kiegroup/droolsjbpm-build-bootstrap/main/.ci/./project-dependencies.yaml.](https://raw.githubusercontent.com/kiegroup/droolsjbpm-build-bootstrap/main/.ci/project-dependencies.yaml.) Error: Status: 301. Moved Permanently
    at getUrlContent (/home/runner/work/_actions/kiegroup/chain-status/main/packages/action/dist/index.js:2:29195)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async loadDependencies (/home/runner/work/_actions/kiegroup/chain-status/main/packages/action/dist/index.js:2:26317)
    at async loadYaml (/home/runner/work/_actions/kiegroup/chain-status/main/packages/action/dist/index.js:2:25860)
    at async getTree (/home/runner/work/_actions/kiegroup/chain-status/main/packages/action/dist/index.js:2:23931)
    at async getOrderedListForTree (/home/runner/work/_actions/kiegroup/chain-status/main/packages/action/dist/index.js:2:26901)
    at async main (/home/runner/work/_actions/kiegroup/chain-status/main/packages/action/dist/index.js:14:217349)
    at async main (/home/runner/work/_actions/kiegroup/chain-status/main/packages/action/dist/index.js:14:210628)
    at async start (/home/runner/work/_actions/kiegroup/chain-status/main/packages/action/dist/index.js:14:209465)

@mareknovotny
Copy link
Member

hmm, there were no changes and it complains about

Error: Error getting https://raw.githubusercontent.com/kiegroup/droolsjbpm-build-bootstrap/main/.ci/./project-dependencies.yaml. Error: Status: 301. Moved Permanently

@mareknovotny
Copy link
Member

maybe @lampajr can help and decode the error msg, but i can't what makes that error 301

@Ginxo
Copy link
Contributor Author

Ginxo commented Nov 12, 2024

@lampajr
Copy link
Member

lampajr commented Nov 12, 2024

That's weird, I tried using curl and directly with axios (which should be the way build-chain-configuration-reader retrieves the file) and both worked 🫤

Looks like the last succeeded run was around 3rd of July but I couldn't find any relevant change that can motivate this issue.

I guess https://github.com/kiegroup/chain-status/blob/main/packages/action/package.json#L44C11-L44C43 it's too old, wdyt @lampajr ?

that might be, but I don't see why that failure though!

@Ginxo
Copy link
Contributor Author

Ginxo commented Nov 12, 2024

That's weird, I tried using curl and directly with axios (which should be the way build-chain-configuration-reader retrieves the file) and both worked 🫤

Looks like the last succeeded run was around 3rd of July but I couldn't find any relevant change that can motivate this issue.

I guess https://github.com/kiegroup/chain-status/blob/main/packages/action/package.json#L44C11-L44C43 it's too old, wdyt @lampajr ?

that might be, but I don't see why that failure though!

just consider its trying project-dependencies.yaml.` (pay attention to the final dot), so I guess it is adding like kind of extension for the file at the end (or something similar)

@lampajr
Copy link
Member

lampajr commented Nov 13, 2024

just consider its trying project-dependencies.yaml.` (pay attention to the final dot), so I guess it is adding like kind of extension for the file at the end (or something similar)

In that case I would have expecting a 404 and not a 301, so I don't think it is actually using that final dot (it is just added as part of the exception/error msg I think)

@mareknovotny
Copy link
Member

so with merged kiegroup/chain-status#63 i think we can close this PR.

@mareknovotny mareknovotny deleted the Ginxo-patch-1 branch November 15, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants