Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: add workaround for smee-client issue 156 #949

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

winklerm
Copy link
Contributor

Add workaround for [1] by building smee-client from a fork with the fix [2].

[1] probot/smee-client#156
[2] probot/smee-client#162

How to retest a PR or trigger a specific build:

* a pull request please add comment: Jenkins retest this

Add workaround for [1] by building smee-client from a fork with the fix
[2].

[1] probot/smee-client#156
[2] probot/smee-client#162
@winklerm winklerm requested review from Ginxo and mbiarnes March 25, 2021 14:37
@winklerm
Copy link
Contributor Author

This is a workaround which needs to be removed as soon as probot/smee-client#162 is merged and a new smee-client released.

Tested on Jenkins.

@winklerm winklerm marked this pull request as ready for review March 25, 2021 14:47
Copy link
Contributor

@mbiarnes mbiarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbiarnes mbiarnes merged commit d89ebe5 into kiegroup:master Mar 25, 2021
@winklerm winklerm deleted the workaroundForSmeeClientHeaderBug branch March 25, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants