-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KIECLOUD-422] move admin user/pwd to statusDescriptors #508
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tchughesiv The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What happened here? Did you change your strategy RE displaying the default RedHat password to users? |
@bmozaffa yes... further testing reveals that randomly generated passwords (the most important ones to display) are in status only. unfortunately, the |
/lgtm |
ac8ef52
to
1bd1e10
Compare
1d52248
to
83da133
Compare
/lgtm |
83da133
to
47919ac
Compare
New changes are detected. LGTM label has been removed. |
Signed-off-by: tchughesiv <[email protected]>
47919ac
to
998eb09
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@tchughesiv: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tchughesiv: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
i guess we can close this as outdated, right @tchughesiv |
Dependant on openshift/console#6697
We'll need to wait for a later operator release. Once the above is merged. Then, we'll need to target the operator version that aligns with whatever OCP version these console password type enhancements are released with. Which appears to be 4.7.
Signed-off-by: tchughesiv [email protected]