[9.100.x-prod] No-issue: Prod build config fixes (#24) (#25)

* Prod build config fixes * Change the mvn lifecycle to download FE libs * Add comments for future memory
kiegroup · May 28, 2024 · a06ad4c · a06ad4c
1 parent b96006b
commit a06ad4c
Show file tree

Hide file tree

Showing 6 changed files with 34 additions and 5 deletions.
diff --git a/packages/serverless-workflow-diagram-editor/appformer-bom/pom.xml b/packages/serverless-workflow-diagram-editor/appformer-bom/pom.xml
@@ -73,6 +73,7 @@
   <properties>
     <sonar.skip>true</sonar.skip>
     <version.j2cl.tools>0.1</version.j2cl.tools>
+    <version.deploy.plugin>2.8.2</version.deploy.plugin>
   </properties>
 
   <dependencyManagement>
@@ -353,4 +354,15 @@
     </dependencies>
   </dependencyManagement>
 
+  <build>
+    <pluginManagement>
+      <plugins>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-deploy-plugin</artifactId>
+          <version>${version.deploy.plugin}</version>
+        </plugin>
+      </plugins>
+    </pluginManagement>
+  </build>
 </project>
diff --git a/packages/serverless-workflow-diagram-editor/kie-wb-common-bom/pom.xml b/packages/serverless-workflow-diagram-editor/kie-wb-common-bom/pom.xml
@@ -73,6 +73,7 @@
   <properties>
     <sonar.skip>true</sonar.skip>
     <j2cl.tools.version>0.1</j2cl.tools.version>
+    <version.deploy.plugin>2.8.2</version.deploy.plugin>
   </properties>
 
   <dependencyManagement>
@@ -230,4 +231,16 @@
     </dependencies>
   </dependencyManagement>
 
+  <build>
+    <pluginManagement>
+      <plugins>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-deploy-plugin</artifactId>
+          <version>${version.deploy.plugin}</version>
+        </plugin>
+      </plugins>
+    </pluginManagement>
+  </build>
+
 </project>
diff --git a/...r/kie-wb-common-stunner/kie-wb-common-stunner-client/kie-wb-common-stunner-lienzo/pom.xml b/...r/kie-wb-common-stunner/kie-wb-common-stunner-client/kie-wb-common-stunner-lienzo/pom.xml
@@ -172,7 +172,8 @@
             <executions>
                 <execution>
                     <id>unpack-external-dependencies</id>
-                    <phase>generate-resources</phase>
+                    <!-- Please use generate-sources instead of generate-resources to download the libraries before the build  -->
+                    <phase>generate-sources</phase>
                     <goals>
                         <goal>unpack</goal>
                     </goals>
@@ -216,7 +217,8 @@
             <executions>
                 <execution>
                     <id>rename-files</id>
-                    <phase>process-resources</phase>
+                    <!-- Please use process-sources instead of process-resources to process the libraries before the build  -->
+                    <phase>process-sources</phase>
                     <goals>
                         <goal>rename</goal>
                     </goals>

diff --git a/packages/sonataflow-deployment-webapp/pom.xml b/packages/sonataflow-deployment-webapp/pom.xml
@@ -48,6 +48,7 @@
         <maven.compiler.target>11</maven.compiler.target>
         <maven.compiler.release>11</maven.compiler.release>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <version.deploy.plugin>2.8.2</version.deploy.plugin>
     </properties>
 
     <dependencies>
@@ -108,7 +109,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-deploy-plugin</artifactId>
-                <version>3.1.1</version>
+                <version>${version.deploy.plugin}</version>
                 <executions>
                     <execution>
                         <id>deploy-webjar</id>

diff --git a/packages/sonataflow-quarkus-devui/pom.xml b/packages/sonataflow-quarkus-devui/pom.xml
@@ -95,7 +95,8 @@
             </goals>
             <configuration>
               <skip>${skip.ui.build}</skip>
-              <arguments>-F serverless-workflow-dev-ui-webapp... !@kie-tools/dmn-marshaller-backend-compatibility-tester build:prod</arguments>
+	      <pnpmInheritsProxyConfigFromMaven>false</pnpmInheritsProxyConfigFromMaven>
+              <arguments>-F serverless-workflow-dev-ui-webapp... -F !@kie-tools/dmn-marshaller-backend-compatibility-tester -F !@kie-tools/dmn-testing-models build:prod</arguments>
               <environmentVariables>
                 <KIE_TOOLS_BUILD__runTests>false</KIE_TOOLS_BUILD__runTests>
                 <KIE_TOOLS_BUILD__runIntegrationTests>false</KIE_TOOLS_BUILD__runIntegrationTests>

diff --git a/pom.xml b/pom.xml
@@ -56,7 +56,7 @@
     <version.frontend.plugin>1.15.0</version.frontend.plugin>
     <version.node>v18.16.0</version.node>
     <version.npm>6.10.3</version.npm>
-    <version.pnpm>v8.7.0</version.pnpm>
+    <version.pnpm>8.7.0</version.pnpm>
 
     <quarkus.platform.version>3.2.10.Final</quarkus.platform.version>
     <version.org.kie.kogito>999-SNAPSHOT</version.org.kie.kogito>