Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.101.x-prod][SRVLOGIC-384] - Productize OpenShift Serverless Logic Management Console Image #45

Merged
merged 8 commits into from
Sep 16, 2024

Conversation

ricardozanini
Copy link
Member

@ricardozanini ricardozanini commented Sep 12, 2024

In this PR:

  • Added a new package named osl-management-console-image to handle productization requirements
  • Added a new script that can be used on other prod packages in the future to update the target module.yaml with artifacts md5

Please see the Readme file for instructions and try the image locally. Only works on x86 for now.

@ricardozanini ricardozanini marked this pull request as ready for review September 13, 2024 18:26
@ricardozanini ricardozanini changed the title [SRVLOGIC-384] - Productize OpenShift Serverless Logic Management Console Image [9.101.x-prod][SRVLOGIC-384] - Productize OpenShift Serverless Logic Management Console Image Sep 13, 2024
export SONATAFLOW_MANAGEMENT_CONSOLE__registry=registry.access.redhat.com
export SONATAFLOW_MANAGEMENT_CONSOLE__account=openshift-serverless-1
export SONATAFLOW_MANAGEMENT_CONSOLE__name=logic-management-console-rhel8
export SONATAFLOW_MANAGEMENT_CONSOLE__buildTag=1.34

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rgdoliveira @ricardozanini double checking if this shouldn't be 1.34.*0*

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@domhanak This is just an example. Cekit will override the tag in runtime.

Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
Signed-off-by: Ricardo Zanini <[email protected]>
@rgdoliveira rgdoliveira merged commit c915c9f into kiegroup:9.101.x-prod Sep 16, 2024
0 of 5 checks passed
@rgdoliveira
Copy link
Member

@ricardozanini I've merge this one, please let me know when you create the PR to midstream main branch.
As we talked on slack, the one from main branch does not need to have the generated/ files, those can be created and pushed only for prod branches when we start a release.

@ricardozanini ricardozanini deleted the srvlogic-384 branch September 16, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants