Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and tidy up #96

Merged
merged 39 commits into from
Mar 10, 2024
Merged

Refactor and tidy up #96

merged 39 commits into from
Mar 10, 2024

Conversation

kieran-mackle
Copy link
Owner

Major refactor to improve code readability, organisation and performance.

  • AutoData has been deprecated, and instead the broker instances hold the methods necessary to load data.
  • Strategies are now only provided the current datetime in generate_signal, and are able to communicate directly with the broker to fetch OHLCV data if required.
  • The AutoTrader Demo repo has been updated to reflect this

pboachie and others added 30 commits February 7, 2024 21:39
@pboachie
Add handling for empty trades in position_histories_dict
5fffde6
@kieran-mackle
style: lint with black
816f6a0
@kieran-mackle
Merge branch 'pboachie-development' into development
d6f13a8
@kieran-mackle
style: made docstrings more readable
d8056cf
@kieran-mackle
fix(DataStream): use generalised data fetch methods of AutoData
112a91d 
closes #93
@kieran-mackle
fix(AutoPlot): fixed plotting nav timezone bug
5527195
@kieran-mackle
feat(Strategy): added strategy base class
6198dea
@kieran-mackle
feat: added ability for bots to kill instance
e55ecbf
@kieran-mackle
feat(Broker): added broker base class
8b08175
@kieran-mackle
style(AutoBot): add type hints for inherited attributes
43b26e4
@kieran-mackle
style(AutoTrader): add type hints and improve docstrings
67721e6
@kieran-mackle
feat(Broker): ccxt broker will translate native TP/SL to ccxt params
06f8172
@kieran-mackle
fix(Broker): use _safe_add method to update ccxt_params
ed1d052
@kieran-mackle
feat(utilities.py): added logger function
1574388
@kieran-mackle
feat: using logging throughout
f67c67d
@kieran-mackle
fix: log handling and ccxt instrument precisions
876365a
@kieran-mackle
docs(README.md): added to news section
576327f
@kieran-mackle
Merge remote-tracking branch 'origin/main' into development
4552d32
@kieran-mackle
style(AutoTrader): remove newline character in log message
10b971e
@kieran-mackle
fix(AutoTrader): logging arguments
a01a210
@kieran-mackle
fix(AutoTrader): handling of logger kwargs
566f9ee
@kieran-mackle
style(AutoTrader): only print banner when stdout is true
ff91c4b
@kieran-mackle
style: adjust logging verbosity when running backtest mode
b70d39b
@kieran-mackle
style: reviewed code and made comments for improvements
05f0534
@kieran-mackle
refactor(data): renamed data to package_data for clarity
402fb64
@kieran-mackle
refactor: major refactor of entire project
d1a7612 
BREAKING CHANGE:
@kieran-mackle
build(setup.py): change minimum python version to 3.11
4e07f33
@kieran-mackle
refactor: simplified broker module strucutre
34de57b 
also tidied obsolete methods and arguments
@kieran-mackle
feat(utilities.py): added ccxt-download data stream object
aae4f74
@kieran-mackle
fix: pass logging config to brokers
1eb06b5
@kieran-mackle kieran-mackle merged commit 5d162c0 into main Mar 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kieran-mackle @pboachie