updated the index.html file #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following are the changes that I've made: 1. Changed the heading tag from h1 to h2 because in the mini project it was mentioned that the heading should be of either h2 or h3. 2. Corrected a typo that is changed quotes to Quotes 3.Added the emphasis tag to the heading to make an emphasis on it. 4.Added a line between the heading and the quote, quote and the author name and between the author name and button to make it a bit more representable.
|
@Shreya23-tech thanks for the PR, but please understand the code base on which you have committed is owned by @Faizan-Alam-1 . |
|
Thankyou,
for the comment. Actually I'm new to open source project contribution so I
don't know much about where should I contribute and all. Hopefully mr.
Faizan accepts it.
…On Wed, Oct 7, 2020, 22:06 Rajesh Kumbhakar ***@***.***> wrote:
@Shreya23-tech <https://github.com/Shreya23-tech> thanks for the PR, but
please understand the code base on which you have committed is owned by
@Faizan-Alam-1 <https://github.com/Faizan-Alam-1> .
So @Faizan-Alam-1 <https://github.com/Faizan-Alam-1> do you accept this
commit?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFZV2YX7OFV73NIZSKKPZLSJSKIFANCNFSM4SHQD6OA>
.
|
|
@Shreya23-tech Sorry we can't accept your code. Your ### Br tag Messing Up Our Code. Sorry try Again. |
|
@Shreya23-tech try to fix what @Faizan-Alam-1 mentioned. |
|
Ohkay Sir, I'll try to fix it and will update. Sir, I had made 2 more pull
requests few days ago, I request you sir to look into them and guide me.
Thankyou!
…On Fri, Oct 9, 2020, 22:11 Rajesh Kumbhakar ***@***.***> wrote:
@Shreya23-tech <https://github.com/Shreya23-tech> try to fix what
@Faizan-Alam-1 <https://github.com/Faizan-Alam-1> mentioned.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFZV23KTHJTA2EYL3ODZBDSJ44MDANCNFSM4SHQD6OA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following are the changes that I've made:
3.Added the emphasis tag to the heading to make an emphasis on it.
4.Added a line between the heading and the quote, quote and the author name and between the author name and button to make it a bit more representable.