Skip to content

Cleanup interface #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025
Merged

Cleanup interface #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f077725
Cleanup interface
kullingk Jun 18, 2025
fef1a6b
Fix review findings
kullingk Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions include/cppcore/Common/TBitField.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ template <class T>
class TBitField {
public:
/// @brief The default class constructor.
TBitField();
TBitField() = default;

/// @brief The class constructor with the initial value.
/// @param[in] init The init value.
Expand All @@ -48,12 +48,12 @@ class TBitField {

/// @brief Returns the current bit-mask.
/// @return The bitmask.
T GetMask() const;
T getMask() const;

/// @brief Will return the bit at the given position.
/// @param[in] pos The bit position for readout.
/// @return true for bit is set, false for not.
bool getBit(size_t pos) const;
bool constexpr getBit(size_t pos) const noexcept ;

/// @brief Will set the bit at the given position to the given state.
/// @param[in] pos The bit position for write.
Expand All @@ -76,28 +76,21 @@ class TBitField {
size_t maxBits() const;

private:
T mBitMask;
T mBitMask{0};
};

template <class T>
inline TBitField<T>::TBitField() :
mBitMask(0) {
inline TBitField<T>::TBitField(T init) : mBitMask(init) {
// empty
}

template <class T>
inline TBitField<T>::TBitField(T init) :
mBitMask(init) {
// empty
}

template <class T>
inline T TBitField<T>::GetMask() const {
inline T TBitField<T>::getMask() const {
return mBitMask;
}

template <class T>
inline bool TBitField<T>::getBit(size_t pos) const {
inline bool constexpr TBitField<T>::getBit(size_t pos) const noexcept {
assert(pos < maxBits());
return (mBitMask & (1 << pos)) != 0;
}
Expand Down