Fix: Error is thrown when menu item can not be found

kimyvgy · Feb 17, 2019 · cc01244 · cc01244
1 parent 34b0e86
commit cc01244
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/scrollspy.js b/src/scrollspy.js
@@ -25,11 +25,14 @@ export class ScrollSpy {
     const section = this.getSectionInView()
     const menuItem = this.getMenuItemBySection(section)
 
-    this.removeCurrentActive({ ignore: menuItem })
-    this.setActive(menuItem)
+    if (menuItem) {
+      this.removeCurrentActive({ ignore: menuItem })
+      this.setActive(menuItem)
+    }
   }
 
   getMenuItemBySection(section) {
+    if (!section) return
     const sectionId = section.getAttribute('id')
     return this.menuList.querySelector(`[${this.options.hrefAttribute}="#${sectionId}"]`)
   }