-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ios-sdk.mdx #299
Update ios-sdk.mdx #299
Conversation
WalkthroughThe pull request introduces documentation updates for the Kinde iOS SDK, focusing on logging functionality. A new section titled "Custom Logger (Optional)" has been added to explain how developers can implement custom logging by extending the Changes
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/content/docs/developer-tools/sdks/native/ios-sdk.mdx (2)
109-112
: Enhance the custom logger introductionThe section would benefit from:
- Explaining why someone might want to use custom logging
- Mentioning the default
Logger
class and its capabilities- Adding a reference to any logging-related configuration options
128-130
: Fix typo in error messageThere's a typo in the error message prefix.
- print("[ERORR]: \(error.localizedDescription)") + print("[ERROR]: \(error.localizedDescription)")
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/content/docs/developer-tools/sdks/native/ios-sdk.mdx
(1 hunks)
🔇 Additional comments (1)
src/content/docs/developer-tools/sdks/native/ios-sdk.mdx (1)
102-102
: Document the breaking change in SDK configuration
The removal of the named parameter logger:
in KindeSDKAPI.configure()
could break existing implementations. Consider adding:
- A migration note for existing users
- Version information where this change was introduced
Description (required)
Related issues & labels (optional)
Summary by CodeRabbit
New Features
Documentation