-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: expo export
script failing for web
#6
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes in Changes
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Explain your changes
We were experiencing an error "Metro error: window is not defined" when using the
expo export
script. We're specially using the export script for Expo router API routes but this would also impact users using expo web builds needing to use theexpo export
script.To reproduce the error:
npx create-expo-app@latest
pnpm @kinde-oss/expo
@kinde-oss/expo
component such asKindeAuthProvider
npx expo export
I have published this to an internal package and it has fixed the
expo export
script.Checklist
🛟 If you need help, consider asking for advice over in the Kinde community.