-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing norwegian translations #73
fix: add missing norwegian translations #73
Conversation
After mobile authentication was added, some translations were missing.
Important Review SkippedReview was skipped due to path filters Files ignored due to path filters (1)
You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@@ -25,6 +25,16 @@ | |||
"country_input_error_invalid": "Et gyldig land er påkrevd", | |||
"choose_another_method_link": "Velg en annen metode" | |||
}, | |||
"mfa_email_page": { | |||
"page_title": "Skriv inn e-post | ${business_name}", | |||
"heading": "Autentiser via e-post", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Autentiser" is not a common word for non-technical people in Norway (typically our end users, at least), so it would probably be better to say "Logg inn via e-post" or something like that for this translation. But since I'm not sure of the context this is shown in, and the mfa_sms_page translations also used "autentiser", I'll just use it to keep consistency :)
Explain your changes
After mobile authentication was added, some translations were missing. I know the context of the
phone_number_component
texts in the Kinde webpage, but the other texts I added after the validation script noted they were missing. Disclaimer: I have not reviewed the other translations visually, so I cannot be 100% sure they are good microcopy for the context they are used in.I have no experience as a translator, but I have worked as proofreader for some Norwegian publishers when I was younger.
This PR is fixing, amongst other things, missing translations like:
Checklist