Vietnamese Added #74
Merged
Vietnamese Added #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe change to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (4)
README.md (4)
Line range hint
3-3: Consider revising the sentence for clarity.- This repo contains all the translation files for Kinde public facing screens e.g auth flows + This repo contains all the translation files for Kinde public facing screens, e.g., auth flowsTools
Markdownlint
116-116: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style)
Table pipe style
117-117: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style)
Table pipe style
119-119: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style)
Table pipe style
121-121: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style)
Table pipe style
116-116: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count)
Table column count
117-117: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count)
Table column count
119-119: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count)
Table column count
121-121: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count)
Table column count
Line range hint
9-9: Clarify the instructions for adding new languages.- here are the steps to do so: + here are the steps to take:This minor change improves the readability and correctness of the instruction.
Tools
Markdownlint
116-116: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style)
Table pipe style
117-117: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style)
Table pipe style
119-119: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style)
Table pipe style
121-121: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style)
Table pipe style
116-116: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count)
Table column count
117-117: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count)
Table column count
119-119: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count)
Table column count
121-121: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count)
Table column count
Line range hint
136-136: Add a blank line before the fenced code block for proper Markdown formatting.+ ```sh pip3 install jsonschema<details> <summary>Tools</summary> <details> <summary>Markdownlint</summary><blockquote> 116-116: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 117-117: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 119-119: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 121-121: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 116-116: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 117-117: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 119-119: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 121-121: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count </blockquote></details> </details> --- Line range hint `36-122`: Ensure proper table formatting in Markdown. Many rows in the language table are missing trailing pipes, which could lead to formatting issues. Please ensure each row ends with a pipe to maintain consistency and correct display in Markdown viewers. <details> <summary>Tools</summary> <details> <summary>Markdownlint</summary><blockquote> 116-116: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 117-117: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 119-119: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 121-121: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 116-116: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 117-117: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 119-119: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 121-121: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count </blockquote></details> </details> </blockquote></details> </blockquote></details> <details> <summary>Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** <details> <summary>Commits</summary> Files that changed from the base of the PR and between d36b4229c3ab2940eb287409219707a35b127e76 and c71e75c4278736011852a2fd26c1ab52a8907f95. </details> <details> <summary>Files ignored due to path filters (1)</summary> * `vi/auth.json` is excluded by `!**/*.json` </details> <details> <summary>Files selected for processing (1)</summary> * README.md (1 hunks) </details> <details> <summary>Additional context used</summary> <details> <summary>LanguageTool</summary><blockquote> <details> <summary>README.md</summary><blockquote> [uncategorized] ~3-~3: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA) Context: ...anslation files for Kinde public facing screens e.g auth flows [ requires two periods. (E_G) Context: ...n files for Kinde public facing screens e.g auth flows [ Context: ...nguage supported by Kinde, here are the steps to do so: 1. Fork this repo. 2. Please crea... </blockquote></details> </blockquote></details> <details> <summary>Markdownlint</summary><blockquote> <details> <summary>README.md</summary><blockquote> 28-28: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces) Trailing spaces --- 136-136: null (MD031, blanks-around-fences) Fenced code blocks should be surrounded by blank lines --- 36-36: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 37-37: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 38-38: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 40-40: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 41-41: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 42-42: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 43-43: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 44-44: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 46-46: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 49-49: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 55-55: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 56-56: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 57-57: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 58-58: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 60-60: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 63-63: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 64-64: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 65-65: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 67-67: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 68-68: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 70-70: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 71-71: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 73-73: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 76-76: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 77-77: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 78-78: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 79-79: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 80-80: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 81-81: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 82-82: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 83-83: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 85-85: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 86-86: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 87-87: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 88-88: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 90-90: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 91-91: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 94-94: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 95-95: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 97-97: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 99-99: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 104-104: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 105-105: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 106-106: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 107-107: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 108-108: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 110-110: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 111-111: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 112-112: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 113-113: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 116-116: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 117-117: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 119-119: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 121-121: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 122-122: Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe (MD055, table-pipe-style) Table pipe style --- 36-36: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 37-37: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 38-38: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 40-40: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 41-41: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 42-42: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 43-43: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 44-44: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 46-46: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 49-49: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 55-55: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 56-56: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 57-57: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 58-58: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 60-60: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 63-63: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 64-64: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 65-65: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 67-67: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 68-68: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 70-70: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 71-71: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 73-73: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 76-76: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 77-77: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 78-78: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 79-79: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 80-80: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 81-81: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 82-82: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 83-83: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 85-85: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 86-86: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 87-87: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 88-88: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 90-90: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 91-91: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 94-94: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 95-95: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 97-97: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 99-99: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 104-104: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 105-105: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 106-106: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 107-107: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 108-108: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 110-110: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 111-111: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 112-112: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 113-113: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 116-116: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 117-117: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 119-119: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 121-121: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count --- 122-122: Expected: 3; Actual: 2; Too few cells, row will be missing data (MD056, table-column-count) Table column count </blockquote></details> </blockquote></details> </details> <details> <summary>Additional comments not posted (1)</summary><blockquote> <details> <summary>README.md (1)</summary><blockquote> `118-118`: Successfully marked Vietnamese as available. This update correctly follows the PR's objective and the outlined steps in the README for adding a new language translation. </blockquote></details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
DaveOrDead
approved these changes
Jun 26, 2024
|
Thanks @abel3t - sorry for the delay 🚀 |
|
Thank you @DaveOrDead! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes
I added Vietnamese (vi).
Checklist
🛟 If you need help, consider asking for advice over in the Kinde community.