chore: cleanup #109
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,66 +1,11 @@ | ||
| import globals from 'globals'; | ||
| import pluginJs from '@eslint/js'; | ||
| import tseslint from 'typescript-eslint'; | ||
|
Comment on lines
+1
to
+3
There was a problem hiding this comment. 💡 Verification agent 🧩 Analysis chainCI failing: missing 'globals' dependency; add it or avoid the import Build pipeline error: "Cannot find package 'globals'". Add it to devDependencies (preferred) or drop the dependency and inline minimal globals. Option A (add dependency): --- a/package.json
+++ b/package.json
@@
"devDependencies": {
+ "globals": "^15.0.0"
}
}Option B (avoid dependency; inline minimal globals): -import globals from 'globals';
+const browserGlobals = { window: 'readonly', document: 'readonly', navigator: 'readonly' };
@@
-export default defineConfig([
- { languageOptions: { globals: globals.browser } },
+export default defineConfig([
+ { languageOptions: { globals: browserGlobals } },Additionally, to fix Node globals for scripts (and remove no-undef comments), scope Node globals: + { files: ['sdk-version.js', 'scripts/**'], languageOptions: { globals: { process: 'readonly', __dirname: 'readonly', module: 'readonly', require: 'readonly' } } },After applying, re-run ESLint locally/CI. Also applies to: 7-11 🏁 Script executed: #!/bin/bash
node -v
npm ls globals || echo "globals not installed"
npx eslint . -vLength of output: 232 Add missing ‘globals’ package (or inline minimal globals) to fix ESLint CI --- a/package.json
+++ b/package.json
@@ -...devDependencies
"devDependencies": {
+ "globals": "^15.0.0"
}Option B: inline minimal browser globals in eslint.config.mjs -import globals from 'globals';
+const browserGlobals = { window: 'readonly', document: 'readonly', navigator: 'readonly' };
@@
-export default defineConfig([
- { languageOptions: { globals: globals.browser } },
+export default defineConfig([
+ { languageOptions: { globals: browserGlobals } },Also scope Node globals for scripts: + { files: ['sdk-version.js', 'scripts/**'], languageOptions: { globals: { process: 'readonly', __dirname: 'readonly', module: 'readonly', require: 'readonly' } } },Re-run ESLint locally/CI to confirm.
🧰 Tools🪛 GitHub Actions: Build and test TypeScript SDK CI[error] 1-1: ESLint failed: Cannot find package 'globals' imported from eslint.config.mjs. Did you mean to import [email protected]/node_modules/globals/index.js? 🤖 Prompt for AI Agents |
||
| import { defineConfig, globalIgnores } from 'eslint/config'; | ||
|
|
||
| export default defineConfig([ | ||
| { languageOptions: { globals: globals.browser } }, | ||
| globalIgnores(['dist', 'node_modules', 'coverage/**', 'dist-cjs']), | ||
| pluginJs.configs.recommended, | ||
| ...tseslint.configs.recommended, | ||
| ]); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| { | ||
| "name": "@kinde-oss/kinde-typescript-sdk", | ||
| "version": "2.14.0-5", | ||
| "description": "Kinde Typescript SDK", | ||
| "main": "dist-cjs/index.js", | ||
| "module": "dist/index.js", | ||
| "type": "module", | ||
| "types": "dist/types/index.d.ts", | ||
| "files": [ | ||
| "dist", | ||
|
|
@@ -24,7 +25,7 @@ | |
| "scripts": { | ||
| "build": "npm run generate && tsc && tsc -p tsconfig.cjs.json", | ||
| "postbuild": "node sdk-version.js clean && ncp ./package-cjs.json ./dist-cjs/package.json && ncp ./package-esm.json ./dist/package.json", | ||
| "prebuild": "node sdk-version.js && rimraf dist dist-cjs", | ||
| "lint": "eslint . && prettier . --check", | ||
| "lint:fix": "eslint --fix . && prettier . --write", | ||
| "test": "vitest", | ||
|
|
@@ -47,18 +48,13 @@ | |
| "license": "MIT", | ||
| "devDependencies": { | ||
| "@openapitools/openapi-generator-cli": "^2.7.0", | ||
| "@types/jsdom": "^21.1.1", | ||
| "typescript-eslint": "^8.41.0", | ||
| "@eslint/js": "^9.34.0", | ||
| "@types/node": "^22.0.0", | ||
| "@typescript-eslint/eslint-plugin": "^8.0.0", | ||
| "@vitest/coverage-v8": "^1.3.1", | ||
| "eslint": "^9.24.0", | ||
| "husky": "^9.0.0", | ||
| "jose": "^6.0.10", | ||
| "jsdom": "^26.0.0", | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect compare link in 2.13.1 header
"compare/4.6.2...2.13.1" appears wrong; likely should compare v2.13.0...v2.13.1.
📝 Committable suggestion
🤖 Prompt for AI Agents