Fixes for issues in IE11 #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix two issues with IE11: (1) Calendar does not position correctly. Replace window.scrollX/scrollY with window.pageXOffset/pageYOffset to make it work in all browsers (2) Calendar can't be removed. Replace el.destroy() (not supported in pre-Edge IE) with el.parentElement.removeChild(el) to make it work in all browsers
Open
|
This fix worked for me. I was able to reproduce it in IE11 and applying this fix corrected it. |
|
Same for me. Thanks for this fix! |
uella
approved these changes
Oct 20, 2016
|
I am facing this same issue, can you merge? This works. |
|
Please merge |
|
Thank you for the fix works a treat :) |
|
Could anyone merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues with IE11:
(1) Calendar does not position correctly. Replaces window.scrollX/scrollY with window.pageXOffset/pageYOffset to make it work in all browsers.
(2) Calendar can't be removed once rendered. Replaces el.destroy() (not supported in pre-Edge IE) with el.parentElement.removeChild(el) to make it work in all browsers.
Also adds a missing comma in package.json.
Minified version also rebuilt and included.