forked from apache/hive
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
HIVE-20032: Don't serialize hashCode for repartitionAndSortWithinPart…
…itions (Sahil Takiar, reviewed by Rui Li)
- Loading branch information
1 parent
94ec368
commit 1e437e2
Showing
14 changed files
with
208 additions
and
42 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
kryo-registrator/src/main/java/org/apache/hive/spark/NoHashCodeKryoSerializer.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * <p> | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * <p> | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.hive.spark; | ||
|
|
||
| import com.esotericsoftware.kryo.Kryo; | ||
| import com.esotericsoftware.kryo.Serializer; | ||
| import com.esotericsoftware.kryo.io.Input; | ||
| import com.esotericsoftware.kryo.io.Output; | ||
|
|
||
| import org.apache.hadoop.hive.ql.io.HiveKey; | ||
| import org.apache.hadoop.io.BytesWritable; | ||
| import org.apache.spark.SparkConf; | ||
| import org.apache.spark.serializer.KryoSerializer; | ||
|
|
||
|
|
||
| /** | ||
| * A {@link KryoSerializer} that does not serialize hash codes while serializing a | ||
| * {@link HiveKey}. This decreases the amount of data to be shuffled during a Spark shuffle. | ||
| */ | ||
| public class NoHashCodeKryoSerializer extends KryoSerializer { | ||
|
|
||
| private static final long serialVersionUID = 3350910170041648022L; | ||
|
|
||
| public NoHashCodeKryoSerializer(SparkConf conf) { | ||
| super(conf); | ||
| } | ||
|
|
||
| @Override | ||
| public Kryo newKryo() { | ||
| Kryo kryo = super.newKryo(); | ||
| kryo.register(HiveKey.class, new HiveKeySerializer()); | ||
| kryo.register(BytesWritable.class, new HiveKryoRegistrator.BytesWritableSerializer()); | ||
| return kryo; | ||
| } | ||
|
|
||
| private static class HiveKeySerializer extends Serializer<HiveKey> { | ||
|
|
||
| public void write(Kryo kryo, Output output, HiveKey object) { | ||
| output.writeVarInt(object.getLength(), true); | ||
| output.write(object.getBytes(), 0, object.getLength()); | ||
| } | ||
|
|
||
| public HiveKey read(Kryo kryo, Input input, Class<HiveKey> type) { | ||
| int len = input.readVarInt(true); | ||
| byte[] bytes = new byte[len]; | ||
| input.readBytes(bytes); | ||
| return new HiveKey(bytes); | ||
| } | ||
| } | ||
| } |
62 changes: 62 additions & 0 deletions
62
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/ShuffleKryoSerializer.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * <p/> | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * <p/> | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.hadoop.hive.ql.exec.spark; | ||
|
|
||
| import org.apache.hadoop.conf.Configuration; | ||
| import org.apache.hive.spark.client.SparkClientUtilities; | ||
| import org.apache.spark.SparkConf; | ||
| import org.apache.spark.api.java.JavaSparkContext; | ||
|
|
||
| import java.io.FileNotFoundException; | ||
| import java.lang.reflect.InvocationTargetException; | ||
| import java.net.MalformedURLException; | ||
|
|
||
|
|
||
| final class ShuffleKryoSerializer { | ||
|
|
||
| private static final String HIVE_SHUFFLE_KRYO_SERIALIZER = "org.apache.hive.spark.NoHashCodeKryoSerializer"; | ||
|
|
||
| private static org.apache.spark.serializer.KryoSerializer INSTANCE; | ||
|
|
||
| private ShuffleKryoSerializer() { | ||
| // Don't create me | ||
| } | ||
|
|
||
| static org.apache.spark.serializer.KryoSerializer getInstance(JavaSparkContext sc, | ||
| Configuration conf) { | ||
| if (INSTANCE == null) { | ||
| synchronized (ShuffleKryoSerializer.class) { | ||
| if (INSTANCE == null) { | ||
| try { | ||
| INSTANCE = (org.apache.spark.serializer.KryoSerializer) Thread.currentThread().getContextClassLoader().loadClass( | ||
| HIVE_SHUFFLE_KRYO_SERIALIZER).getConstructor(SparkConf.class).newInstance( | ||
| sc.getConf()); | ||
| return INSTANCE; | ||
| } catch (InstantiationException | IllegalAccessException | InvocationTargetException | NoSuchMethodException | ClassNotFoundException e) { | ||
| throw new IllegalStateException( | ||
| "Unable to create kryo serializer for shuffle RDDs using " + | ||
| "class " + HIVE_SHUFFLE_KRYO_SERIALIZER, e); | ||
| } | ||
| } else { | ||
| return INSTANCE; | ||
| } | ||
| } | ||
| } | ||
| return INSTANCE; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.