-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix split_bases and split_indices for ElementVector #1091
Conversation
Yes, ElementVector dim kwarg is not used too much in the examples/tests. |
Yay, thanks for merging so quickly! |
I'm still considering whether we should also add numpy<2 at the same time because the release is in 2-3 months and I expect there to be issues with "pip install scikit-fem[all]". I already fixed most of the issues within scikit-fem in #1090 but matplotlib and meshio are currently broken so it might affect UX here unless it is done. What do you think? |
Pinning now would also lead to quite a bit of trouble - if someone has numpy pre-installed, pinning now would lead to an older version of scikit-fem being installed, which would cause even more trouble :/ I'd guess the best would be to just go on releasing and add a warning at import which lists the current problems and suggests downgrading numpy in case? |
I don't think that should happen. I won't drop support for numpy<2 within scikit-fem any time soon as the changes are very minimal and the users of anaconda or other older numpy version should be able to install whatever version, no matter what numpy version they use. I'm proposing to add numpy<2 for the short time that the issues with the dependencies are solved. Something along the lines: https://pythonspeed.com/articles/numpy-2/ |
Perhaps it is not necessary and I'm just overthinking. I've been also considering to fork |
There is now a release 9.0.1 coming in few hours. |
At those two lines it should be the number of dimensions of the
ElementVector
not the number of dimensions of the mesh, right?(I'm having a 3D vector in a 2D mesh)