Clarify expression alias logic #110
Conversation
| ExpressionAlias = namedtuple('ExpressionAlias', 'regular, hashed') | ||
|
|
||
| # Non-standard expression aliases | ||
| EXPR_ALIASES = { |
There was a problem hiding this comment.
Also pulls this up into the module scope so we're not redeclaring this mapping every time
There was a problem hiding this comment.
moving the aliases top module level would be ok, but not in favor of a namedtuple because users shall be allowed to update easily the aliases.
Another problem is that this change is not at all retrocompatible. To allow retrocompat, maybe using a class attribute that dictcopy the module level one would be a solution.
There was a problem hiding this comment.
Damn, the above comment was not validated, so you didnt saw it... sorry :(
There was a problem hiding this comment.
users shall be allowed to update easily the aliases.
What makes it difficult to update the aliases because we're using a named tuple? Could you share an example of what you're thinking that is more difficult?
There was a problem hiding this comment.
dict are mutable, not namedtuple.
There was a problem hiding this comment.
You could just replace it like this though right
# Replace alias with whatever you want
EXPR_ALIASES['@midnight'] = ExpressionAlias("1 2 * * *", "h h * * *")
evanpurkhiser
force-pushed
the
simplify-expr-alises
branch
from
0d4b136
to
dd01378
Compare
kiorky
force-pushed
the
master
branch
3 times, most recently
from
06366ef
to
fcf5ff8
Compare
evanpurkhiser
force-pushed
the
simplify-expr-alises
branch
from
dd01378
to
dc080ae
Compare
|
Updated to fix remove the conflict |
oups, the other pr i just merged broke it again :( :) . |
|
I'll get it fixed after I get the black formatting done :) |
Instead of using tuple indexing use a namedtuple mapped from the expression aliases. This makes readability / understanding of this logic a little easier.
evanpurkhiser
force-pushed
the
simplify-expr-alises
branch
from
dc080ae
to
e051743
Compare
|
Going to close this one out since this one's a bit controversial. Feel free to pull from parts of it though if you'd like! |
When i started to review #136 & & #135, what i saw is that it will be hard for someone else to do the relevant changes and so i started to do it myself as some spaghetti code that needs to be removed to implement clearly DST :-/. TBH, i though i could finish DST rework, i have NOW a large diff which is on the go locally, but is not finished yet. I hope to finish that soon with a better state that it is now. |
Instead of using tuple indexing use a namedtuple mapped from the expression aliases. This makes readability / understanding of this logic a little easier.