Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

black: Apply to tests #127

Closed
wants to merge 1 commit into from

Conversation

evanpurkhiser
Copy link
Contributor

I don't expect to merge this right away as is, since there's a lot of formatting I think black might do that's not optimal.

I'll try and add some comment call out for weird things.

However, I do think it will be pretty safe to merge this without so many small PRs since

  1. Test code is not run in production, so the chance that something is broken that is shipped to production is pretty much zero.
  2. If it runs in CI, the code works. There won't be any rogue syntax errors if CI doesn't fail.

@evanpurkhiser
Copy link
Contributor Author

Have to run to an invterview. Will try and get the last bit of PRs up after. Thank you for reviewing everything @kiorky !!

I will start looking at the DST bugs today as well.

self.assertRaises(ValueError, croniter, "0-10/error * * * *")
self.assertRaises(ValueError, croniter, "0-10/ * * * *")
self.assertRaises(
CroniterBadCronError, croniter, "0-1& * * * *", datetime.now()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linelength 120 should fix spurious linereturn.

self.assertEqual(croniter("0 0 * 1 0-6").expanded[dow], wildcard)
self.assertEqual(croniter("0 0 1 1 0-6").expanded[dow], [0, 1, 2, 3, 4, 5, 6])
self.assertEqual(
croniter("0 0 1 1 0-6,sat#3").expanded[dow], [0, 1, 2, 3, 4, 5, 6]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem

3,
4,
5,
6,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those one should not be reformated as it is unreadable as is :)

"24 4",
"24 6",
"24 8",
"24 10",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem

@kiorky
Copy link
Owner

kiorky commented Oct 30, 2024

Have to run to an invterview. Will try and get the last bit of PRs up after. Thank you for reviewing everything @kiorky !!

I will start looking at the DST bugs today as well.

ok, just to let you know that i'm on CET timezone so i ll be off soon, and will look then tomorrow. lots of thanks too for your work here !

@evanpurkhiser
Copy link
Contributor Author

I'll at least split this into things like quotes 👍 and turn some formatting off for the egregious lists

@kiorky
Copy link
Owner

kiorky commented Oct 31, 2024

Do you see anything left to do for tests formatting ?

@evanpurkhiser
Copy link
Contributor Author

Nah this sohuld be done.

@evanpurkhiser evanpurkhiser deleted the black-tests branch October 31, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants