-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
black: Apply to tests #127
Conversation
Have to run to an invterview. Will try and get the last bit of PRs up after. Thank you for reviewing everything @kiorky !! I will start looking at the DST bugs today as well. |
self.assertRaises(ValueError, croniter, "0-10/error * * * *") | ||
self.assertRaises(ValueError, croniter, "0-10/ * * * *") | ||
self.assertRaises( | ||
CroniterBadCronError, croniter, "0-1& * * * *", datetime.now() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linelength 120 should fix spurious linereturn.
self.assertEqual(croniter("0 0 * 1 0-6").expanded[dow], wildcard) | ||
self.assertEqual(croniter("0 0 1 1 0-6").expanded[dow], [0, 1, 2, 3, 4, 5, 6]) | ||
self.assertEqual( | ||
croniter("0 0 1 1 0-6,sat#3").expanded[dow], [0, 1, 2, 3, 4, 5, 6] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idem
3, | ||
4, | ||
5, | ||
6, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those one should not be reformated as it is unreadable as is :)
"24 4", | ||
"24 6", | ||
"24 8", | ||
"24 10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idem
ok, just to let you know that i'm on |
I'll at least split this into things like quotes 👍 and turn some formatting off for the egregious lists |
Do you see anything left to do for tests formatting ? |
Nah this sohuld be done. |
I don't expect to merge this right away as is, since there's a lot of formatting I think black might do that's not optimal.
I'll try and add some comment call out for weird things.
However, I do think it will be pretty safe to merge this without so many small PRs since