All black changes (meta PR do not merge) #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted a few of these to not use explicit string concatenation. I did leave one or two that were egregiously long otherwise. This is also using line length 119 now.
Follow up from kiorky#119
Uses fmt: off for these since they produce very long lists
evanpurkhiser
force-pushed
the
all-black
branch
4 times, most recently
from
b4c7d59
to
a7314e8
Compare
None of the other files have this in them
evanpurkhiser
force-pushed
the
all-black
branch
6 times, most recently
from
77fcac5
to
7ebeece
Compare
- Adds a new tox `check-format` command - Locks black to the last version supporting python 2 - Configures black using pyproject.toml (unfortunately it cannot be configured using tox.ini, see psf/black#2172)
evanpurkhiser
force-pushed
the
all-black
branch
from
7ebeece
to
97bd844
Compare
|
i cherrypicked / rebased all the commits except the black one as we wil merge it at the end. |
|
everything is merged in, even the black setup. |
|
Woohoo!!! thanks for getting this all merged! |
|
Probably overkill but this really does make it a lot easier to contribute! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This is an integration PR just to show that all test pass with what the final integration looks like.
I wasn't able to open every PR as a commit, but @kiorky when you're back online, if thee individual commits look good to you feel free to pull them into master
221b902 → #128
f5d6c6f → #131
3f1a5f3 → #130
6945be4 → #129
dd1311a → #132
cd5f2b4 → [no PR yet, feel free to pull in]
e62d330 → [no PR yet, feel free to pull in]
58bdc7a → [no PR yet, feel free to pull in]
f7c9320 → [no PR yet, feel free to pull in]
6bd5f88 → [no PR yet, feel free to pull in]
97bd844 → #123
Part of #99