Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DOM and DOW parsing logic #34

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Update DOM and DOW parsing logic #34

merged 1 commit into from
Sep 27, 2024

Conversation

kipe
Copy link
Owner

@kipe kipe commented Sep 27, 2024

  • Added a special case handling when both 'day' fields are set to allow either one to match. This addresses issue Behavior for day checking is incorrect #29.
  • Updated the parsing logic for 'dom' and 'dow' arguments, using _parse_arg function with appropriate default values.

@kipe
Update DOM and DOW parsing logic
e8181dd 
- Added a special case handling when both 'day' fields are set to allow either one to match. This addresses issue #29.
- Updated the parsing logic for 'dom' and 'dow' arguments, using `_parse_arg` function with appropriate default values.
@kipe kipe self-assigned this Sep 27, 2024
@kipe kipe linked an issue Sep 27, 2024 that may be closed by this pull request
Behavior for day checking is incorrect #29
Closed
@kipe kipe merged commit 47a960a into main Sep 27, 2024
8 checks passed
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling e8181dd on 29-behavior-for-day-checking-is-incorrect
into 05b277c on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kipe kipe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Behavior for day checking is incorrect
2 participants
@kipe @coveralls