Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: More pkgcheck warn cleanups #21

Merged
merged 20 commits into from
Sep 13, 2024
Merged

CI: More pkgcheck warn cleanups #21

merged 20 commits into from
Sep 13, 2024

Conversation

kir68k
Copy link
Owner

@kir68k kir68k commented Sep 11, 2024

Better as a PR. Includes updates in separate commits to any packages listed in the last run as of 3822d30, linked here.

Commit order should be done this way:

  1. Any available updates
    • One commit per package
  2. Pkgcheck cleanup for warnings, info if I have time
    • One commit per category, message being e.g. "CI: media-video pkgcheck cleanup"

For clarity's sake, and if I ever want to revisit a change.

Signed-off-by: Kirin Etheridge <[email protected]>
"spcomp-bin-[PV]-r[GITREV]" is improper in every way.
Both ebuilds are now similar to Semantic Versioning.

Signed-off-by: Kirin Etheridge <[email protected]>
I actively dislike and don't use Hyprland, where ags is mostly used.
Handling npm+meson in an offline sandbox is also not fun.

Personally.

Signed-off-by: Kirin Etheridge <[email protected]>
@kir68k
Copy link
Owner Author

kir68k commented Sep 11, 2024

Ok I'll continue tomorrow it's 2 am, that's why

@kir68k
Copy link
Owner Author

kir68k commented Sep 12, 2024

^ lol

Should've mentioned earlier; commit 7835d21 undoes what was done in this issue: #9

Removes both packages. Unable to use on AMD without superuser
privileges.
More info in issue #22

Closes #22

Signed-off-by: Kirin Etheridge <[email protected]>
Signed-off-by: Kirin Etheridge <[email protected]>
Not sure why it ever was here? No differences from the main tree.

Signed-off-by: Kirin Etheridge <[email protected]>
@kir68k
Copy link
Owner Author

kir68k commented Sep 12, 2024

About ac914d9, I was confused why so many files even use tabs when I clearly set vim.opt.expandtab = true in Neovim's init.lua...

Apparently "/etc/vim/sysinit.vim" enforces this for ebuild/eclass files and references this from gentoo.org, which now gives a 404:

  " Gentoo-specific settings for ebuilds.  These are the federally-mandated
  " required tab settings.  See the following for more information:
  " http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml
  " Note that the rules below are very minimal and don't cover everything.
  " Better to emerge app-vim/gentoo-syntax, which provides full syntax,
  " filetype and indent settings for all things Gentoo.
  au BufRead,BufNewFile *.e{build,class} set ts=4 sw=4 noexpandtab

Now for one gentoo-syntax never worked for me with Neovim, only plain vim, but I also find it hard to believe tabs would be preferred ("federally-mandated") in 2024...

Cleans up any warnings/info output from messages for:
- dev-util/
- games-util/

Signed-off-by: Kirin Etheridge <[email protected]>
@kir68k
Copy link
Owner Author

kir68k commented Sep 12, 2024

... What mostly irritates me about this is how I'm unable to test locally; pkgcheck gives a completely different result and messes with the metadata directory (which should probably be deleted, #19)

In 4ec7654 I cleaned a warning entry from games-util/r2mod_cli, but got two harmless/info entries,,, not sure how long it'll take me to remember the correct order (remember, gentoo-syntax templates don't work -_-)

@kir68k
Copy link
Owner Author

kir68k commented Sep 12, 2024

oh god i've been doing so much in the wrong order all this time
note to self: get templates with proper order working in nvim, please

edit: caf887e removed an entry for var order... but i placed another var incorrectly.
i am now going to ignore these, no 100% clean output after all >.>

Please just work this time ;w;

Signed-off-by: Kirin Etheridge <[email protected]>
@kir68k
Copy link
Owner Author

kir68k commented Sep 12, 2024

app-misc/premid I don't want to remove, but will ignore the warning about RESTRICT="network-sandbox", it's unknown to pkgcheck, but is the only way (that I know of) to make that ebuild work.

Packages: Updates PYTHON_COMPAT to support 3.13 on:
- clickgen
- zxcvbn
- toml
- vpk
- PyKCS11

CI: Fixes indentation on zxcvbn/metadata.xml

Signed-off-by: Kirin Etheridge <[email protected]>
Signed-off-by: Kirin Etheridge <[email protected]>
This package's name is not nice for commit titles.
Move this gnome-extra/ package to versioned.

Fixes CI failure for missing Manifest, forgot about that.

Signed-off-by: Kirin Etheridge <[email protected]>
Signed-off-by: Kirin Etheridge <[email protected]>
Signed-off-by: Kirin Etheridge <[email protected]>
Signed-off-by: Kirin Etheridge <[email protected]>
Version 46.1 merged the accent color keys PR.
This package is not really needed in this repo.

Signed-off-by: Kirin Etheridge <[email protected]>
@kir68k kir68k marked this pull request as ready for review September 13, 2024 00:06
@kir68k kir68k merged commit 7e86449 into stream Sep 13, 2024
1 check passed
@kir68k
Copy link
Owner Author

kir68k commented Sep 13, 2024

Oh, wait, I should do this from a terminal instead, forgot about sign-off.

edit 1 second later: meh, all the actual commits are signed off, forget this lel.

@kir68k
Copy link
Owner Author

kir68k commented Sep 13, 2024

Also, even though this is now merged, there are still a few warnings. I wanted to merge these commits fast as they contain package updates, the bigger and more important checks are gone, and I'm temporarily impatient :3.

I'll probably work more on them tomorrow
Time of writing: 02:33

@kir68k
Copy link
Owner Author

kir68k commented Sep 13, 2024

i am now going to ignore these, no 100% clean output after all >.>

I forgot that skel.ebuild exists in the main tree xd
I'll open another PR I guess? Titled "Final pkgcheck cleaning", as I guess this one was called "More" not "All" :v

@kir68k kir68k mentioned this pull request Sep 13, 2024
@kir68k kir68k deleted the pkgcheck-cleanup branch September 14, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant