footerの実装 #43
Open
footerの実装 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 12, 2020 09:11
shxun6934
reviewed
Jan 18, 2020
| shoppingListTabLayout.addOnTabSelectedListener(object: TabLayout.OnTabSelectedListener { | ||
| override fun onTabSelected(tab: TabLayout.Tab) { | ||
| var position = shoppingListTabLayout.selectedTabPosition | ||
| if (position == 0) { |
There was a problem hiding this comment.
ちなみにif文よりもwhen文のほうがいい理由って何ですか？
shxun6934
reviewed
Jan 18, 2020
|
|
||
| override fun onTabReselected(tab: TabLayout.Tab) { | ||
| var position = shoppingListTabLayout.selectedTabPosition | ||
| if (position == 0) { |
|
↑「if文からwhen文に変更」のミスです |
sato-na
changed the base branch from
master
to
createScreen-shoppingList-shinbo
|
マージしたいのでコンフリクト直しておいてください。 |
… into add-tabButton-shinbo
… into add-tabButton-shinbo
sato-na
changed the base branch from
createScreen-shoppingList-shinbo
to
master
|
baseBranchを変更したらコンフリクトが治りました。 |
added 4 commits
February 6, 2020 16:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issueの番号 / Title
#8
どのように解決したか / How
tabLayoutでfooterを作成した
なぜそのような解決策を取ったのか / Why
tabLayoutでfooterを作成した
その他 / スクリーンショットなど
ui作成のプルリクから変更してません