Ensure Python 3.12+ compatibility in check_console_script #448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In f4d046c an assumption was made (correct at the time), that only the importlib.metadata backport,
importlib_metadata
, returns a tuple of entry points.However, importlib.metadata in Python 3.12+ behaves the same.
This caused a KeyError exception to be thrown on Python 3.12, as reported repeatedly be testers of Fedora Linux 39 in:
https://bugzilla.redhat.com/show_bug.cgi?id=2231593
This change adjusts the conditional used in check_console_script to assume both the backport and Python 3.12+ return a tuple.
While not obvious from the test failures output,
this change also fixes the following TestBashGlobal tests failures:
For the reference, the failures looked like this:
Fixes #440