unpack crates into temp/:uuid #83
Conversation
Pull Request Test Coverage Report for Build #96
💛 - Coveralls |
|
This is a workaround around issue #56 for the usage with a service offering ro-crate-java as a REST API. |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @@ -55,6 +62,6 @@ public File readContent(String location) { | |||
| if (!read) { | |||
| this.readCrate(location); | |||
| } | |||
| return new File("temp"); | |||
| return new File(tempFolder); | |||
There was a problem hiding this comment.
💬 4 similar findings have been found in this PR
PATH_TRAVERSAL_IN: This API (java/io/File.(Ljava/lang/String;)V) reads a file whose location might be specified by user input
🔎 Expand here to view all instances of this finding
| File Path | Line Number |
|---|---|
| src/main/java/edu/kit/datamanager/ro_crate/reader/ZipReader.java | 36 |
| src/main/java/edu/kit/datamanager/ro_crate/reader/ZipReader.java | 50 |
| src/main/java/edu/kit/datamanager/ro_crate/reader/ZipReader.java | 29 |
| src/main/java/edu/kit/datamanager/ro_crate/reader/ZipReader.java | 31 |
Visit the Lift Web Console to find more details in your report.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
No description provided.