Merge pull request #430 from kitbagjs/fix-route-props-clearing

src/routeProps.spec.ts

@@ -0,0 +1,30 @@
+import { expect, test, vi } from 'vitest'
+import { createRoute } from './services/createRoute'
+import { createRouter } from './services/createRouter'
+
+test('props are called each time the route is matched', async () => {
+  const props = vi.fn()
+
+  const route = createRoute({
+    name: 'test',
+    path: '/[param]',
+  }, props)
+
+  const router = createRouter([route], {
+    initialUrl: '/',
+  })
+
+  await router.start()
+
+  await router.push('test', { param: 'foo' })
+
+  expect(props).toHaveBeenCalledTimes(1)
+
+  await router.push('test', { param: 'bar' })
+
+  expect(props).toHaveBeenCalledTimes(2)
+
+  await router.push('test', { param: 'foo' })
+
+  expect(props).toHaveBeenCalledTimes(3)
+})

src/services/createPropStore.ts

@@ -134,7 +134,7 @@ export function createPropStore(): PropStore {
   }
 
   function clearUnusedStoreEntries(keysToKeep: string[]): void {
-    for (const key in store.keys()) {
+    for (const key of store.keys()) {
       if (keysToKeep.includes(key)) {
         continue
       }