add "href" property to ResolvedRoute #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kitbag-router ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pleek91
reviewed
Dec 14, 2024
| @@ -39,5 +40,6 @@ export function getResolvedRouteForUrl(routes: Routes, url: string, state?: unkn | |||
| params: getRouteParamValues(route, url), | |||
| state: getStateValues(route.state, state), | |||
| hash, | |||
| href: asUrl(url) | |||
There was a problem hiding this comment.
Seems a little odd we need asUrl. But I get why.
|
|
||
| ```html{3} | ||
| <router-view> | ||
| <template #default={ component, route }> | ||
| <transition name="fade" :key="route.key"> | ||
| <transition name="fade" :key="route.href"> |
There was a problem hiding this comment.
Did you add href to RouterRoute?
| id: route.id, | ||
| matched: route, | ||
| matches: [route], | ||
| name: type, | ||
| query: createResolvedRouteQuery(''), | ||
| params: {}, | ||
| state: {}, | ||
| href: '/', |
There was a problem hiding this comment.
Hmm hard coding this to '/' is interesting. This is really only used for NotFound when the initialUrl doesn't match anything right?
There was a problem hiding this comment.
yes that's where we use this reject route. The actual href of the rejection route is probably never actually used anywhere but required to satisfy the type
Co-authored-by: Craig Harshbarger <[email protected]>
pleek91
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is step 1 of a couple different initiatives.
1.) we need a key that's unique to handle transitions when params change, currently using
route.idbut that won't change when params change. With this newhrefproperty, we will have a better candidate. (this is really just a 1 line docs change, so I decided to commit it here)2.) we want to avoid "widening" the route inside of RouterLink, currently users might use an explicit route name as part of the
ToCallbackwhich uses RouterResolve and returns a Url. Once we "widen" from an explicit route name to a Url, we've found that will sometimes actually point to a different route now, causing a bad DX and confusion.