[1st Attempt] Fix route components remounting rather than being updated when props change #439
+136
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kitbag-router ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stackoverfloweth
approved these changes
Jan 25, 2025
| const SuspenseAsyncComponentPropsWrapper = defineComponent(async (input: { component: Component, props: unknown }) => { | ||
| const values = ref() | ||
|
|
||
| values.value = await input.props |
There was a problem hiding this comment.
So the suspense version is different because it uses top-level await for props, right?
And we only use this version when we know that the current instance has a Vue Suspense component above?
pleek91
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a route's props are updated the components should not be unmounted and recreated. This fixes an issue with how route components and props were combined that was causing new components to get mounted whenever the props changed.
Note
In its current state this PR changes how the default slot of RouterView works. Which I'm hoping can be fixed so that users get the same functionality as before when using the default slot.