feat: register with consul client #10
Open
+37
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rfyiamcool Hello，rebase 下 master 代码 |
baiyutang
reviewed
May 8, 2024
README.md
Outdated
| @@ -143,7 +147,7 @@ func main() { | |||
|
|
|||
| ## Example | |||
|
|
|||
| See Server and Client in example/basic or example/custom-config. | |||
| See Server and Client in [example/basic](https://github.com/rfyiamcool/registry-consul/tree/main/example/basic) or [example/custom-config](https://github.com/rfyiamcool/registry-consul/tree/main/example/custom-config). | |||
There was a problem hiding this comment.
the link should be kitex-contrib/registry-consul
There was a problem hiding this comment.
@rfyiamcool 劳烦及时跟进下代码，过久的PR 可能会被关闭哈
rfyiamcool
force-pushed
the
feat/register_with_client
branch
2 times, most recently
from
8b15aa9
to
743128b
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rfyiamcool The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: rfyiamcool <[email protected]>
rfyiamcool
force-pushed
the
feat/register_with_client
branch
from
743128b
to
d66e480
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
NewConsulRegisterWithClientfunction. because app already consul client at startup, don't create client again.health checkis not used. because some network architectures are complicate, consul cannot connect to the registered node. 😁 It will be more friendly to explain in the documentation.