Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Fix some typos (most of them found by codespell) #1163

Merged
merged 3 commits into from
Feb 4, 2024

Conversation

stweil
Copy link
Member

@stweil stweil commented Feb 3, 2024

No description provided.

Most of them were found and fixed using codespell.

Signed-off-by: Stefan Weil <[email protected]>
@stweil stweil changed the title Fix some typos (most of them found by codespell) [MAINTENANCE] Fix some typos (most of them found by codespell) Feb 3, 2024
@sebastian-meyer sebastian-meyer added the 🛠 maintenance A task to keep the code up-to-date and manageable. label Feb 4, 2024
@sebastian-meyer
Copy link
Member

Thank you for the corrections! I'll merge them all, although some of the changes (i. e. those to jPlayer) would need to be fixed upstream to not be reintroduced with the next dependency updates.

@sebastian-meyer sebastian-meyer merged commit 3689a15 into kitodo:master Feb 4, 2024
6 checks passed
@stweil stweil deleted the typo branch February 4, 2024 13:58
@stweil
Copy link
Member Author

stweil commented Feb 4, 2024

The last release of jPlayer was ten years ago, the latest commit is from 2017, and my pull request to fix the typos (jplayer/jPlayer#415) is from 2018. Therefore I don't expect that anything will be fixed there upstream.

I wonder whether we should look for a replacement with recent code. Sticking to ten year old software with two high severity and four moderate severity Dependabot alerts might be a bad idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 maintenance A task to keep the code up-to-date and manageable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants