Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some smaller issues in dependencies #6152

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix some smaller issues in dependencies #6152

wants to merge 2 commits into from

Conversation

stweil
Copy link
Member

@stweil stweil commented Jul 28, 2024

The updates were selected from this list:

mvn versions:display-dependency-updates | grep -- "->" | sort | uniq

@stweil
Copy link
Member Author

stweil commented Jul 28, 2024

The CI test failure is unrelated to this pull request, see #6138.

@stweil stweil force-pushed the dependencies branch 2 times, most recently from 43cc244 to f7d4ee9 Compare July 29, 2024 20:35
@stweil
Copy link
Member Author

stweil commented Jul 30, 2024

I added a commit which adds the missing "test" scope to some dependencies which are only relevant for the tests.

@stweil stweil force-pushed the dependencies branch 3 times, most recently from 53f242b to 6fd113a Compare August 5, 2024 13:02
henning-gerhardt
henning-gerhardt reviewed Aug 5, 2024
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
henning-gerhardt
henning-gerhardt reviewed Aug 5, 2024
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@stweil stweil changed the title Update some dependencies to latest bugfix versions Update some dependencies to latest bugfix versions and more commits related to dependencies Aug 5, 2024
henning-gerhardt
henning-gerhardt reviewed Aug 26, 2024
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
stweil
stweil commented Aug 26, 2024
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
stweil
stweil commented Oct 7, 2024
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@stweil stweil mentioned this pull request Oct 7, 2024
Merged
@stweil stweil added the dependencies Pull requests that update a dependency file label Oct 7, 2024
henning-gerhardt
henning-gerhardt reviewed Oct 8, 2024
View reviewed changes
Kitodo-Query-URL-Import/pom.xml Outdated
@@ -47,6 +47,7 @@
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest</artifactId>
<scope>test</scope>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed as defined in parent as test scope.

henning-gerhardt
henning-gerhardt reviewed Oct 8, 2024
View reviewed changes
Kitodo-XML-SchemaConverter/pom.xml Outdated
@@ -43,6 +43,7 @@
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest</artifactId>
<scope>test</scope>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed as defined in parent as test scope.

henning-gerhardt
henning-gerhardt reviewed Oct 8, 2024
View reviewed changes
Kitodo/pom.xml Outdated
@@ -233,6 +233,7 @@
<dependency>
<groupId>org.xmlunit</groupId>
<artifactId>xmlunit-matchers</artifactId>
<scope>test</scope>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed as defined in parent as test scope.

Copy link
Member Author

@stweil stweil Oct 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a test scope for xmlunit-matchers in my latest pom.xml.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You add the right scope in your current pull request and as the scopes are passed to the sub modules you did not define it again. As already written in my post above.

henning-gerhardt
henning-gerhardt reviewed Oct 8, 2024
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
henning-gerhardt
henning-gerhardt suggested changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@henning-gerhardt henning-gerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is only a reading and compiling review. I can not test the changes itself in a working environment.

@henning-gerhardt
Copy link
Collaborator

Ignore my review and this should be reviewed by an other person.

@stweil stweil force-pushed the dependencies branch 3 times, most recently from dfea134 to 3dc9aa3 Compare October 11, 2024 14:22
@stweil stweil mentioned this pull request Oct 11, 2024
Merged
@stweil
Fix typos in comments in root pom.xml
9a8b3c4 
Signed-off-by: Stefan Weil <[email protected]>
@stweil
Add missing "test" scope to some dependencies
894c93b 
The missing scopes were reported by `mvn dependency:analyze`.

Signed-off-by: Stefan Weil <[email protected]>
@stweil
Copy link
Member Author

stweil commented Oct 31, 2024

Rebased + fixed merge conflict.

@stweil stweil changed the title Update some dependencies to latest bugfix versions and more commits related to dependencies Fix some smaller issues in dependencies Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henning-gerhardt henning-gerhardt henning-gerhardt requested changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stweil @henning-gerhardt