TASK: Avoid accessing "global" request, response and arguments in action controller #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
force-pushed
the
task/actioncontroller-simplecontroller-review-2
branch
2 times, most recently
from
62a1f36 to
cc15e4c
Compare
mhsdesign
commented
Jan 27, 2024
mhsdesign
commented
Jan 27, 2024
mhsdesign
commented
Jan 27, 2024
| @@ -560,12 +560,12 @@ protected function callActionMethod(ActionRequest $request, ActionResponse $resp | |||
| } | |||
|
|
|||
| if ($actionResult === null && $this->view instanceof ViewInterface) { | |||
| $this->response = $this->renderView($this->response); | |||
| $response = $this->renderView($response); | |||
There was a problem hiding this comment.
this assignment on $this->response was a thorn in my eyes
mhsdesign
commented
Jan 27, 2024
| @@ -260,8 +260,7 @@ public function processRequest(ActionRequest $request): ActionResponse | |||
| $this->initializeView($this->view); | |||
| } | |||
|
|
|||
| // We still use a global response here as it might have been changed in any of the steps above | |||
There was a problem hiding this comment.
if someone dared to replace $this->response above - not just mutate the object!!! - i dont know what i should think.
mhsdesign
force-pushed
the
task/actioncontroller-simplecontroller-review-2
branch
from
c956b23 to
44f5356
Compare
|
I extracted the standalone parts into own prs like neos#3292 so this might actually be merged directly into your feature branch, without to big of a diff. |
mhsdesign
force-pushed
the
task/actioncontroller-simplecontroller-review-2
branch
from
44f5356 to
03f7367
Compare
mhsdesign
changed the title
mhsdesign
force-pushed
the
task/actioncontroller-simplecontroller-review-2
branch
from
03f7367 to
d9b881d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for neos#3232