Fix kiwi://extensions on small screens #732
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kiwibrowser I would appreciate if you could trigger CI build, since GitHub Actions on my fork do not have necessary token and I couldn't find docs about building Kiwi from full source on Linux (or any other platform). |
|
This is basically a "hello world" PR to test out build system and process while fixing a minor thing. |
Huge
suggested changes
Nov 12, 2022
| @@ -68,6 +68,13 @@ | |||
| --cr-toolbar-field-max-width: var(--cr-toolbar-center-basis); | |||
| --cr-toolbar-field-width: 100%; | |||
| } | |||
|
|
|||
| /* On small screens hide the toggle label so to live space for toggle itself. */ | |||
| @@ -68,6 +68,13 @@ | |||
| --cr-toolbar-field-max-width: var(--cr-toolbar-center-basis); | |||
| --cr-toolbar-field-width: 100%; | |||
| } | |||
|
|
|||
| /* On small screens hide the toggle label so to live space for toggle itself. */ | |||
| @media (max-width: 400px) { | |||
There was a problem hiding this comment.
not sure setting a (large enough though )constant is a good practice.
|
Great effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not tested on real build yet (waiting for CI)
This PR fixes visual issues of
kiwi://extensionson small screens (less than 400 virtual pixels):There was a way to access the toggle, but it was not intuitive (click on "search" icon to hide page label, then hold and swipe the toggle).
Before
Screenshot made on Kiwi 105.0.5195.33 on Samsung Galaxy S20 FE:
After:
Screenshot made on Chromium on PC (real Kiwi screenshot coming later):
