Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Commit

Permalink
fix(localization): Fix typo in Hotels' translations
Browse files Browse the repository at this point in the history
This commit also silences ESLint warnings in `e2e/` folder for the rule `adeira/valid-test-folder` as that folder only contains tests: it would be redundant to create a `__tests__/` folder for each subfolder in `e2e/`.
  • Loading branch information
RobinCsl authored and tbergquist-godaddy committed Jan 6, 2020
1 parent 3f35163 commit e6b3d81
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
5 changes: 5 additions & 0 deletions e2e/.eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"rules": {
"adeira/valid-test-folder": "off"
}
}
4 changes: 1 addition & 3 deletions e2e/hotels/hotelDetails/notEnoughBeds.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,7 @@ describe('Hotel detail - Not enough beds warning', () => {
await pressBookNow();

await expect(
element(
by.label("Thats's fine").and(by.type('_UIAlertControllerActionView')),
),
element(by.label("That's fine").and(by.type('_UIAlertControllerActionView'))),
).toBeVisible();
});
});
2 changes: 1 addition & 1 deletion packages/localization/src/vocabularies/Hotels.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ const HotelsVocabulary = {
'single_hotel.book_now.alert_title': 'Not enough beds for everyone',
'single_hotel.book_now.alert_body':
'Your selection accommodates less than __numberOfGuests__ persons',
'single_hotel.book_now.alert_ok': "Thats's fine",
'single_hotel.book_now.alert_ok': "That's fine",
'single_hotel.description.facilities.show_less': 'Show less',
'single_hotel.description.facilities.show_more': 'More',
'single_hotel.hotel_detail_screen.hotel_not_found': 'Hotel not found.',
Expand Down

0 comments on commit e6b3d81

Please sign in to comment.