Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a warning when a button is used inside of AlertDialog's content slot instead of actions slot #545

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Add a warning when a button is used inside of AlertDialog's content slot instead of actions slot #545

merged 2 commits into from
Sep 29, 2023

Conversation

shanio
Copy link
Contributor

@shanio shanio commented Sep 29, 2023 •
edited
Loading

closes #469

@shanio shanio requested a review from a team as a code owner September 29, 2023 11:27
@shanio shanio force-pushed the lint_dialog_buttons_in_content_slot branch from ca4a1f7 to 3252f9a Compare September 29, 2023 11:47
@shanio shanio added feature New feature or request semver:minor PRs marker as minor will force next release to bump MINOR version labels Sep 29, 2023
@hrach hrach added this to the Q3/2023 milestone Sep 29, 2023
@hrach hrach merged commit 2eb100a into main Sep 29, 2023
1 check passed
@hrach hrach deleted the lint_dialog_buttons_in_content_slot branch September 29, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrach hrach hrach approved these changes

Assignees
No one assigned
Labels
feature New feature or request semver:minor PRs marker as minor will force next release to bump MINOR version
Projects
None yet
Milestone
Q3/2023
Development

Successfully merging this pull request may close these issues.

Alert usage lint - put buttons to actions slot.
2 participants
@shanio @hrach