Unify identifier and accessibility modifier #723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelHolec
changed the title
identifier(_:AccessibilityID) convenience modifieridentifier(_:AccessibilityID) convenience modifier
PavelHolec
changed the title
identifier(_:AccessibilityID) convenience modifier
|
Seems like an antipattern to me 🤷. If we have to have this, why not put it in the app instead? |
PavelHolec
force-pushed
the
659-unify-identifier-and-accessibility-modifier
branch
from
b76e0db to
b3db8b8
Compare
|
Closed, but kept the branch for future reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing call site to specify AccessibilityID also as an Identifier using a single modifier at the same time.